Skip to content

minikube updates #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

minikube updates #1064

wants to merge 2 commits into from

Conversation

cmluciano
Copy link
Member

No description provided.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@cmluciano cmluciano force-pushed the cml/uminikubequick branch from f70545d to 8128552 Compare March 13, 2018 16:22
geeknoid
geeknoid reviewed Apr 2, 2018
View reviewed changes
_docs/setup/kubernetes/quick-start.md
### [Minikube](https://github.com/kubernetes/minikube/releases)
* To install Istio locally, install the latest version of
[Minikube](https://kubernetes.io/docs/getting-started-guides/minikube/) (version 0.25.0 or later).
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "bash" after the triple ticks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this, sec

@geeknoid
Copy link
Contributor

geeknoid commented Apr 2, 2018

Should we go ahead and merge this?

@cmluciano
Copy link
Member Author

This has already been fixed, closing

@cmluciano cmluciano closed this Apr 2, 2018
3ks added a commit to 3ks/istio.io that referenced this pull request Dec 4, 2019
@3ks
performance (istio#1064)
2c2f98b
3ks added a commit to 3ks/istio.io that referenced this pull request Dec 4, 2019
@3ks
egress performance istio#1064
d58a81d
istio-testing pushed a commit that referenced this pull request Dec 4, 2019
@3ks @istio-testing
zh-translation: blog series (#5969)
f207adb 
* network policy #1072

* canary #1092

* mixer spof myth #1093

* adapter model #1110

* appwitch #1018

* egress performance #1064

* multicluster version routing #1069

* custom ingress gateway #1086

* fix external link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@geeknoid geeknoid geeknoid left review comments

@gyliu513 gyliu513 gyliu513 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmluciano @googlebot @geeknoid @gyliu513