Skip to content

Fix test fail caused by #8606 #8782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2018
Merged

Fix test fail caused by #8606 #8782

merged 1 commit into from
Sep 18, 2018

Conversation

yangminzhu
Copy link
Contributor

I think #8606 gets merged by the bot without rebasing on the latest change on master. Some PR checked in after also needs to change but not included in #8606.

@PiotrSikora
Copy link
Contributor

Thanks for fixing this!

@hklai @sebastienvas @rkpagadala could you guys figure out why bot is merging stuff that breaks master?

@PiotrSikora
Copy link
Contributor

/lgtm
/approve

@hklai
Copy link
Contributor

hklai commented Sep 17, 2018

@PiotrSikora all required tests passed in #8606.

I think prow always rebase before running tests. @sebastienvas can confirm and help figure out why.

@yangminzhu
Copy link
Contributor Author

/test e2e-dashboard

@PiotrSikora
Copy link
Contributor

@hklai yeah, the tests passed on the change itself, but the merge commit was failing, since there were other changes merged in the meantime that needed updating in the PR.

@PiotrSikora
Copy link
Contributor

/assign @esnible @JimmyCYJ

JimmyCYJ
JimmyCYJ reviewed Sep 17, 2018
View reviewed changes
Copy link
Member

@JimmyCYJ JimmyCYJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hklai
hklai approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, JimmyCYJ, PiotrSikora

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit a3f60d7 into istio:master Sep 18, 2018
@yangminzhu yangminzhu deleted the fixtest branch September 18, 2018 19:22
hklai added a commit that referenced this pull request Sep 18, 2018
@hklai
Revert "Fix test fail caused by #8606 (#8782)"
2d07a52 
This reverts commit a3f60d7.
@hklai hklai mentioned this pull request Sep 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora

@rshriram rshriram Awaiting requested review from rshriram

@liamawhite liamawhite Awaiting requested review from liamawhite

@lizan lizan Awaiting requested review from lizan

2 more reviewers

@JimmyCYJ JimmyCYJ JimmyCYJ left review comments

@hklai hklai hklai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PiotrSikora PiotrSikora

@esnible esnible

@JimmyCYJ JimmyCYJ

@hklai hklai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yangminzhu @PiotrSikora @hklai @istio-testing @JimmyCYJ @esnible @googlebot