[WIP] Update proxy sha #8698
[WIP] Update proxy sha #8698
Conversation
* Fixed the pilot rbac build fail due to envoyproxy/envoy#4250 * Fixed the istioctl test fail due to envoyproxy/envoy#4306
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -24,6 +24,7 @@ import ( | |||
| // Check attributes from a good GET request | |||
| const checkAttributesOkGet = ` | |||
| { | |||
| "context.reporter.uid" : "*", | |||
There was a problem hiding this comment.
Should those really be "*" (i.e. any) and not "" (i.e. empty)?
There was a problem hiding this comment.
I'm not sure actually. @mandarjog I see you added these attributes in proxy, WDYT?
There was a problem hiding this comment.
Those are empty for now, so let's leave them like that for the time being, to avoid silent breakage in the future when someone adds real value, but doesn't update tests (since they would still match "*"), and later something breaks and the value won't be emitted anymore, but the tests will still pass, because empty value matches "*".
I pulled your second commit into my original change in #8606, let's see if it works :)
There was a problem hiding this comment.
Sounds good.
Only the lint is failing in this PR, I think you might need to run dep ensure in your local repo to fix it.
There was a problem hiding this comment.
Yeah, I did that before pushing, so it should be all good. Thanks for the help!
No description provided.