Skip to content

Conversation

sdake
Copy link
Member

@sdake sdake commented Jul 12, 2018

… from 0.8 (#5957)"

This reverts commit 048c291.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested review from myidpt and rshriram July 12, 2018 18:31
@sdake sdake requested review from costinm and removed request for myidpt and rshriram July 12, 2018 18:31
@sdake
Copy link
Member Author

sdake commented Jul 12, 2018

/assign @costinm
/assign @rshriram

Copy link
Contributor

@costinm costinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need both - but it's fine.
We need to remember to re-do this when we merge all PRs to master.

Can you add a DO_NOT_MERGE or other words in the title ?

@costinm costinm changed the title Revert "Restore pulling from master before testing, was lost by merge… DO NOT MERGE TO MASTER: Revert "Restore pulling from master before testing, was lost by merge… Jul 12, 2018
@costinm costinm merged commit 3faec25 into release-1.0 Jul 12, 2018
@rshriram rshriram deleted the revert_merge branch August 7, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants