Skip to content

Conversation

rkpagadala
Copy link
Contributor

  • Fix upgrade TestMain since it is breaking tests.
    Also add helm installer to SimpleTests.

  • Fix errors

* Fix upgrade TestMain since it is breaking tests.
Also add helm installer to SimpleTests.

* Fix errors
Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, rkpagadala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 012136c into istio:release-0.8 Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants