Skip to content

Remove v2 transition commands since everything is now v2 #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2018
Merged

Remove v2 transition commands since everything is now v2 #6665

merged 3 commits into from
Jun 27, 2018

Conversation

GregHanson
Copy link
Member

No description provided.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 27, 2018
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GregHanson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai

Assign the PR to them by writing /assign @hklai in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 27, 2018
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 27, 2018
@codecov
Copy link

codecov bot commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #6665 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6665    +/-   ##
=======================================
- Coverage      68%     68%   -<1%     
=======================================
  Files         361     361            
  Lines       31725   31493   -232     
=======================================
- Hits        21476   21200   -276     
- Misses       9383    9427    +44     
  Partials      866     866
Impacted Files Coverage Δ
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-21%) ⬇️
mixer/adapter/prometheus/server.go 95% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 65% <0%> (ø) ⬇️
pkg/bootstrap/bootstrap_config.go 28% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/encoder.go 99% <0%> (ø) ⬇️
mixer/adapter/cloudwatch/client.go 0% <0%> (ø) ⬆️
pkg/log/options.go 100% <0%> (ø) ⬆️
mixer/adapter/noop/noop.go 100% <0%> (ø) ⬆️
mixer/adapter/denier/denier.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/zap.go 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4827ccb...08fe19a. Read the comment docs.

@istio-testing
Copy link
Collaborator

istio-testing commented Jun 27, 2018 •
edited
Loading

@GregHanson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-dashboard.sh 08fe19a link /test e2e-dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rshriram
rshriram reviewed Jun 27, 2018
View reviewed changes
Makefile
--namespace=istio-system \
--set global.hub=${HUB} \
--values install/kubernetes/helm/istio/values-envoyv2-transition.yaml \
--set gateways.istio-ingressgateway.type=LoadBalancer \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this needed in the generate_yaml above?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore.. its set by default to load balancer..

@rshriram
Copy link
Member

@GregHanson ready to push or need more changes?

@GregHanson GregHanson changed the title [WIP] remove v2 transition commands since everything is now v2 Remove v2 transition commands since everything is now v2 Jun 27, 2018
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 27, 2018
@GregHanson
Copy link
Member Author

@rshriram good to merge

@rshriram rshriram merged commit 6339eb6 into istio:master Jun 27, 2018
@GregHanson GregHanson deleted the remove-transition branch June 27, 2018 18:21
hklai added a commit that referenced this pull request Jun 27, 2018
@hklai
Revert "Remove v2 transition commands since everything is now v2 (#6665…
27a5a60 
…)"

This reverts commit 6339eb6.
hklai added a commit that referenced this pull request Jun 27, 2018
@hklai
Revert "Improve push squashing" (#6677)
a90f565 
* Revert "Remove v2 transition commands since everything is now v2 (#6665)"

This reverts commit 6339eb6.

* Revert "Pilot param clusterRegistriesNamespace should default to pilot namespace (#6446)"

This reverts commit b9294f7.

* Revert "iptable just "return" by uid as the parameter u indicates (#6561)"

This reverts commit 22a0b88.

* Revert "Remove node agent service, residue from flexvolume driver. (#6651)"

This reverts commit db3da82.

* Revert "Continuously reapply galley CA bundle to prevent overwrite (#6599)"

This reverts commit f9e8fd8.

* Revert "Do not count typeConfigs if it is error. (#6527)"

This reverts commit eb1de31.

* Revert "Make racetest green - Fixed data races and flakiness (#6625)"

This reverts commit 30b8ecb.

* Revert "Improve push squashing (#6641)"

This reverts commit 399cd2d.
quanjielin pushed a commit to quanjielin/istio that referenced this pull request Jul 2, 2018
@GregHanson @quanjielin
Remove v2 transition commands since everything is now v2 (istio#6665)
7b95f60 
* remove v2 transition commands since everything is now v2

* changes for transition_loadbalancer_ingressgateway command
quanjielin pushed a commit to quanjielin/istio that referenced this pull request Jul 2, 2018
@hklai @quanjielin
Revert "Improve push squashing" (istio#6677)
b71cadc 
* Revert "Remove v2 transition commands since everything is now v2 (istio#6665)"

This reverts commit 6339eb6.

* Revert "Pilot param clusterRegistriesNamespace should default to pilot namespace (istio#6446)"

This reverts commit b9294f7.

* Revert "iptable just "return" by uid as the parameter u indicates (istio#6561)"

This reverts commit 22a0b88.

* Revert "Remove node agent service, residue from flexvolume driver. (istio#6651)"

This reverts commit db3da82.

* Revert "Continuously reapply galley CA bundle to prevent overwrite (istio#6599)"

This reverts commit f9e8fd8.

* Revert "Do not count typeConfigs if it is error. (istio#6527)"

This reverts commit eb1de31.

* Revert "Make racetest green - Fixed data races and flakiness (istio#6625)"

This reverts commit 30b8ecb.

* Revert "Improve push squashing (istio#6641)"

This reverts commit 399cd2d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@sebastienvas sebastienvas Awaiting requested review from sebastienvas

@geeknoid geeknoid Awaiting requested review from geeknoid

@ostromart ostromart Awaiting requested review from ostromart

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregHanson @istio-testing @rshriram @googlebot