Add edge mixer template. #6408
Add edge mixer template. #6408
Conversation
|
cc @quentinmit |
mixer/template/edge/template.proto
Outdated
| // apiProtocol: api.protocol | "Unknown" | ||
| // contextProtocol: context.protocol | "Unknown" | ||
| // ``` | ||
| message Template { |
There was a problem hiding this comment.
Do we want/need some discussion of edges being between workload instances here?
There was a problem hiding this comment.
I'm not sure that the template dictates what the adapter chooses to constructs the graph based on.
mixer/template/edge/template.proto
Outdated
|
|
||
| // Protocol used | ||
| string context_protocol = 30; | ||
| string api_protocol = 31; |
There was a problem hiding this comment.
Do we imagine extending this to include any of the following:
api.operationdestination.service.name( and/ordestination.service.namespace)connection.mtls
There was a problem hiding this comment.
Those sound reasonable to add, and are likely useful to adapters.
There was a problem hiding this comment.
I decided to just add destination.service.uid, as that can be used to put service nodes in a graph. The others are simply more data about an edge. They seem useful, but there are many attributes that seem useful, I woudln't know where to draw the line. Any useful edge data can be added to the template in the future without breaking backwards compatibility.
| @@ -432,6 +432,24 @@ spec: | |||
| version: v1alpha2 | |||
| --- | |||
|
|
|||
| kind: CustomResourceDefinition | |||
There was a problem hiding this comment.
@guptasu just to confirm, this is still where we are putting new templates, correct?
Codecov Report
@@ Coverage Diff @@
## master #6408 +/- ##
=======================================
- Coverage 71% 71% -<1%
=======================================
Files 353 353
Lines 30814 30717 -97
=======================================
- Hits 21689 21575 -114
- Misses 8273 8299 +26
+ Partials 852 843 -9
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, jeffmendoza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Merge conflicts fixed |
The edge template can be used by adapters that wish to construct a mesh graph based on observed traffic edges.
6afb04f to
2b6b86f
Compare
|
@jeffmendoza: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The edge template can be used by adapters that wish to construct a
mesh graph based on observed traffic edges.