Skip to content

'AGE' column for istioctl #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

'AGE' column for istioctl #6107

wants to merge 2 commits into from

Conversation

esnible
Copy link
Contributor

@esnible esnible commented Jun 8, 2018

Replaces #6013 which I couldn't convince to pass circle tests.

Created using

git checkout master
git checkout -b istioctl_age_v3
git cherry-pick ce78830517b47e961bcdb23a9a8ddd41678ff52f
rm -rf ~/go/pkg/dep/
dep ensure --add k8s.io/apimachinery/pkg/util/duration
git add Gopkg.lock Gopkg.toml vendor
git commit -m "Add dependency to k8s.io/apimachinery/pkg/util/duration"
git push --set-upstream origin istioctl_age_v3

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: esnible
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

Assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

@esnible: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 18692a0 link /test istio-unit-tests
prow/istio-presubmit.sh 18692a0 link /test istio-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible esnible mentioned this pull request Jun 8, 2018
Merged
@esnible
Copy link
Contributor Author

esnible commented Jun 8, 2018

Giving up on this variant.

@esnible esnible closed this Jun 8, 2018
@esnible esnible deleted the istioctl_age_v3 branch June 8, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esnible @istio-testing @googlebot