Add Dockerfile and Makefile rule for nodeagent-k8s image. #5901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanjielin
reviewed
May 30, 2018
| @@ -320,7 +320,7 @@ $(SECURITY_GO_BINS): | |||
|
|
|||
| .PHONY: build | |||
| # Build will rebuild the go binaries. | |||
| build: depend $(PILOT_GO_BINS_SHORT) mixc mixs node_agent istio_ca flexvolume istioctl gals | |||
| build: depend $(PILOT_GO_BINS_SHORT) mixc mixs node_agent nodeagent_k8s istio_ca flexvolume istioctl gals | |||
There was a problem hiding this comment.
do we need to add nodeagent_8ks line#317(SECURITY_GO_BINS:=${ISTIO_OUT}/node_agent...), or you've tested without it is good enough ?
There was a problem hiding this comment.
Good catch! Done.
When I tested locally, I may manually build dependency and then make docker.node-agent-k8s just works implicitly..
Codecov Report
@@ Coverage Diff @@
## gcp-identity #5901 +/- ##
============================================
+ Coverage 73% 73% +1%
============================================
Files 322 322
Lines 27837 27878 +41
============================================
+ Hits 20217 20266 +49
+ Misses 6820 6815 -5
+ Partials 800 797 -3
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: incfly, quanjielin Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @wattli |
wattli
pushed a commit
to wattli/istio
that referenced
this pull request
May 30, 2018
wattli
added a commit
that referenced
this pull request
May 30, 2018
* Restructure the pkg/nodeagent. (#5888) * Move the mesh expansion node agent into the pkg/nodeagent. * Add a gcp subpackage for nodeagent. * Lint formatting. * Add Dockerfile and Makefile rule for nodeagent-k8s image. (#5901) * Ran `dep ensure -update github.com/envoyproxy/go-control-plane` (#5889) * Adding instructions and scripts to facilitate running E2E tests locally (#5838) * Add documents and scripts for k8s+vagrant env. * update macOS setup * Update and rename setup_linux_prereqs.sh to linux_prereqs.sh * Update localregistry.yaml * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update startup.sh * Update README.md * update filename and readme * update readme * update image * Create prereqs.sh * Update README.md * update README * update readme for cleanup * add insecure registry setting onto vm * Add dlv debugging installation to vm setup * Change vm sync folder * Update setup_kubectl_host.sh * Update vm_setup.sh * Create OWNERS (#5130) * Update vm_setup.sh (#5135) * Update Vagrantfile (#5134) * Update README.md (#5138) * Update README.md (#5141) * Update README.md (#5142) * Update README.md (#5154) * Update README.md * Update README.md * Update README.md * Update README.md * Add localregistry.yaml specific for vagrant (#5181) * Create localregistry.yaml * Revert back changes in localregistry.yaml * Updated VagrantFile Updated VagrantFile as per new location of localregistry.yaml * Make test available on macOS (#5177) * update test setup for macos * add local test flag * modify init.sh * update docker check * update env setting * update USE_DOCKER * export GOOS=linux to docker and push targets * Move files out of RunTestOnHost and remove RunTestOnHost and RunTestOnVm. (#5206) * Move files. * Revise per review comments. * Revise per comment. * Polish and simplify README.md (#5211) * Polish and simplify README.md * Update README.md * Update README.md * Rename scripts and cleanup unused scripts. (#5215) * Move files. * Rename scripts and remove unused scripts. * Update README.md * Remove unnecessary env setting (#5217) * remove space at the end of export * modify env changes * Update prerequisites and setup scripts (#5220) * remove space at the end of export * modify env changes * modify setups * update prereqs scripts for macos * Update README.md * Cleanup test_setup.sh and setup_kubelet_config_host.sh (#5230) * Protect Copy to ~/.kube/config_old * Update setup_test.sh * Update setup_dockerdaemon_linux.sh * Push data from help commands to > /dev/null Push data from help commands to > /dev/null as otherwise it fills up screen with too much info and we won't come to know about failures easily * Update setup_test.sh * Update README.md * Update setup_dockerdaemon_linux.sh * Update setup_kubelet_config_host.sh * Create Troubleshooting.md (#5235) * Clean up and update scripts (#5233) * remove space at the end of export * modify env changes * modify setups * update prereqs scripts for macos * modify and cleanup the scripts * rename files * cleanup * update scripts * changes update * update * update Vagrantfile * update local registry setting * add comment back * Update Vagrantfile (#5239) * Update Troubleshooting.md (#5237) * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Small changes to scripts from feedback (#5449) * remove space at the end of export * modify env changes * modify setups * update prereqs scripts for macos * modify and cleanup the scripts * rename files * cleanup * update scripts * changes update * update * update Vagrantfile * update local registry setting * add comment back * Add changes to setup scripts * update kubectl setup script * Separate debian linux distribution (#5515) * Separate debian linux distribution * add default case * Fix download path for kubectl on mac (#5553) * Update Troubleshooting.md (#5240) * Update Troubleshooting.md * Update Troubleshooting.md * Fix minor issues with scripts (#5555) * Update install_prereqs_macos.sh * Update install_prereqs_debian.sh * Update install_prereqs_debian.sh * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Update README.md * Update Troubleshooting.md * Update Troubleshooting.md * Update Troubleshooting.md * Adding version of virtualbox installed * Setup local testing using minikube * Update install_prereqs_debian.sh * Format script * Update cleanup_host.sh * Update cleanup_host.sh * Update setup_host.sh * Revise per comment. * Update go installation. * Revise per comment. * use UDS for mixer (#5930) Signed-off-by: Kuat Yessenov <kuat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make docker.nodeagent-k8swill generate nodeagent-k8s image.