Skip to content

use ISTIO_CP_AUTH variable in cluster.env to enable/disable mTLS for cp in mesh ex #5834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

use ISTIO_CP_AUTH variable in cluster.env to enable/disable mTLS for cp in mesh ex #5834

wants to merge 1 commit into from

Conversation

kidiyoor
Copy link
Contributor

@kidiyoor kidiyoor commented May 24, 2018 •
edited
Loading

ref: #5833

Currently setupMeshEx.sh create a variable CONTROL_PLANE_AUTH_POLICY in cluster.env to enable/disable control plane mTLS for VM.

...
echo "CONTROL_PLANE_AUTH_POLICY=$CP_AUTH_POLICY" >> cluster.env
...

It should be

...
echo "ISTIO_CP_AUTH=$CP_AUTH_POLICY" >> cluster.env
...

since istio-start.sh

istio/tools/deb/istio-start.sh

Line 48 in 26262e8

if [ ! -z "${ISTIO_CP_AUTH:-}" ]; then
looks for ISTIO_CP_AUTH

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kidiyoor
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ijsnellf

Assign the PR to them by writing /assign @ijsnellf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

Hi @kidiyoor. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ymesika
Copy link
Member

ymesika commented May 31, 2018

You probably want to switch target branch to master

@kidiyoor kidiyoor mentioned this pull request May 31, 2018
Merged
@kidiyoor
Copy link
Contributor Author

created a new PR for master - #5950

@kidiyoor kidiyoor closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kidiyoor @istio-testing @ymesika @googlebot