Skip to content

ansible installer needs to support clusters whose versions have multiple digits #5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ansible installer needs to support clusters whose versions have multiple digits #5710

wants to merge 2 commits into from

Conversation

jmazzitelli
Copy link
Member

@jmazzitelli jmazzitelli commented May 18, 2018 •
edited
Loading

I'm running latest minikube, version 1.10.0 (notice the two-digit minor release number). The actual output of kubectl version is:

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-04-27T09:22:21Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

The Istio Ansible Installer fails early during its assert checks because it expects only single-digits for major, minor, and patch release numbers.

This fixes that limitation.

NOTE: this PR has a second commit that also fixes this for OpenShift installations since this bug will also happen when ocp had multiple-digits in versions, too.

@jmazzitelli
Copy link
Member Author

/assign @sbezverk

@jmazzitelli jmazzitelli mentioned this pull request May 21, 2018
Closed
@jmazzitelli
Copy link
Member Author

Can I have a committer look at this and merge when possible? Ansible installer, as it currently is, is broken when using the latest minikube. Need this fix (or something similar) to get it to work.

@gbaufake
Copy link
Member

gbaufake commented Jun 4, 2018

@sdake or @gyliu513

Can you take a look or assign to someone who could do it?

Best Regards!

@codecov
Copy link

codecov bot commented Jun 4, 2018 •
edited
Loading

Codecov Report

Merging #5710 into master will increase coverage by 7%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5710     +/-   ##
========================================
+ Coverage      67%     74%     +7%     
========================================
  Files         333     322     -11     
  Lines       29045   27703   -1342     
========================================
+ Hits        19298   20241    +943     
+ Misses       8977    6666   -2311     
- Partials      770     796     +26
Impacted Files Coverage Δ
...ilot/pkg/networking/plugin/authn/authentication.go 68% <0%> (-15%) ⬇️
pilot/pkg/model/authentication.go 57% <0%> (-15%) ⬇️
mixer/adapter/kubernetesenv/cache.go 73% <0%> (-10%) ⬇️
pilot/pkg/proxy/envoy/v2/discovery.go 68% <0%> (-8%) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (-5%) ⬇️
mixer/adapter/servicecontrol/servicecontrol.go 63% <0%> (-4%) ⬇️
mixer/adapter/prometheus/server.go 97% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 65% <0%> (-3%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 68% <0%> (-2%) ⬇️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5732ea9...c28b07f. Read the comment docs.

@jmazzitelli
I'm running latest minikube, version 1.10.0 (notice the two-digit min…
a9057c4 
…or release number).

The Istio Ansible Installer fails because it expects only single-digits for major, minor, and patch release numbers.

This fixes that limitation.

NOTE: this PR ONLY fixes this for k8s. I assume the same will happen when ocp had multiple-digits, but because this PR is to address k8s installation only, that is all I am fixing here.
@jmazzitelli
since ansible installer looks to be mainly used for ocp installations…
c28b07f 
…, I figure better fix the installer for installing in ocp, too.
@jmazzitelli
Copy link
Member Author

Since it looks like the ansible installer is going to be used mainly for ocp installations, I added a second commit to also fix this bug for ocp versions, as well.

@jmazzitelli jmazzitelli changed the title ansible installer needs to support latest minikube version 1.10.0 ansible installer needs to support clusters whose versions have multiple digits Jun 4, 2018
gyliu513
gyliu513 reviewed Jun 5, 2018
View reviewed changes
Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/ok-to-test

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gyliu513, jmazzitelli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sbezverk

Assign the PR to them by writing /assign @sbezverk in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyliu513
Copy link
Member

gyliu513 commented Jun 5, 2018

/cc @sdake can you help check if we can have this merged?

@gyliu513
Copy link
Member

gyliu513 commented Jun 5, 2018

/ok-to-test

@istio-testing
Copy link
Collaborator

@jmazzitelli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh c28b07f link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 10, 2018
@istio-testing
Copy link
Collaborator

@jmazzitelli: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmazzitelli
Copy link
Member Author

I'm not even sure if this is relevant anymore... it seems helm is going to be the way forward for installing Istio. Is the Ansible Installer still under active development? I am assuming it will no longer be used (??)

This was referenced Jun 10, 2018
Closed
Merged
@ymesika
Copy link
Member

ymesika commented Jun 17, 2018

This has already been fixed upstream.

@ymesika ymesika closed this Jun 17, 2018
@jmazzitelli jmazzitelli deleted the fix-k8s-installer branch January 31, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gyliu513 gyliu513 gyliu513 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@gyliu513 gyliu513

@sbezverk sbezverk

Labels
needs-rebase Indicates a PR needs to be rebased before being merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmazzitelli @gbaufake @istio-testing @gyliu513 @ymesika @googlebot @sbezverk