Skip to content

Moves mesh expansion mode node agent libraries into pkg/nodeagent. #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Moves mesh expansion mode node agent libraries into pkg/nodeagent. #5210

wants to merge 4 commits into from

Conversation

incfly
Copy link

@incfly incfly commented Apr 25, 2018 •
edited
Loading

#4190

There're some weird dependency from pkg/nodeagent/registry/ to vm.Config, that's mostly because we thrust CAClientConfig into naConfig. This can be fixed later.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt

Assign the PR to them by writing /assign @myidpt in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm vadimeisenbergibm mentioned this pull request Apr 30, 2018
Merged
@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #5210 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #5210    +/-   ##
=======================================
- Coverage      74%     73%   -<1%     
=======================================
  Files         323     319     -4     
  Lines       27179   26495   -684     
=======================================
- Hits        19986   19283   -703     
- Misses       6404    6434    +30     
+ Partials      789     778    -11
Impacted Files Coverage Δ
security/pkg/nodeagent/registry/server.go 43% <ø> (ø) ⬆️
security/pkg/nodeagent/vm/nodeagent.go 91% <ø> (ø)
security/pkg/nodeagent/vm/nafactory.go 79% <ø> (ø)
security/pkg/nodeagent/vm/config.go 100% <ø> (ø)
pilot/pkg/model/jwks_resolver.go 56% <0%> (-21%) ⬇️
mixer/adapter/servicecontrol/handler.go 39% <0%> (-7%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 63% <0%> (-4%) ⬇️
mixer/adapter/stackdriver/log/log.go 69% <0%> (-4%) ⬇️
mixer/adapter/kubernetesenv/cache.go 83% <0%> (-2%) ⬇️
...ilot/pkg/networking/plugin/authn/authentication.go 67% <0%> (ø) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e2b90...e69f5c2. Read the comment docs.

@istio-testing
Copy link
Collaborator

@incfly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e.sh e69f5c2 link /test istio-pilot-e2e
prow/e2e-bookInfoTests-v1alpha3.sh e69f5c2 link /test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@incfly
Copy link
Author

incfly commented May 30, 2018

Done in #5888

@incfly incfly closed this May 30, 2018
@incfly incfly deleted the pr-pkg branch May 30, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myidpt myidpt Awaiting requested review from myidpt

@mangchiandjjoe mangchiandjjoe Awaiting requested review from mangchiandjjoe

@wattli wattli Awaiting requested review from wattli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@incfly @istio-testing @googlebot