[test pr] check if 503s and other known bugs are fixed #5102
Conversation
removing the t.Skip() Should fail in CI until we have a fix
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We already have a test for 503.. And this test will likely never pass because its using old v1 and old v1alpha1 format. |
where ? |
Thanks Andra for pointing out that version should fail/work the same as using pod IP directly as the destination container never sees the original cluster IP
Codecov Report
@@ Coverage Diff @@
## master #5102 +/- ##
=======================================
+ Coverage 73% 74% +1%
=======================================
Files 319 319
Lines 26363 26570 +207
=======================================
+ Hits 19164 19413 +249
+ Misses 6420 6375 -45
- Partials 779 782 +3
Continue to review full report at Codecov.
|
Service vip doesn’t exist for non existent port and we need a non existent port to get the bad routing behavior
|
this got accidentally merged, I undid the accident and will redo the PR now |
|
@ldemailly: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@andraxylia can you please retroactively approve the comment and yaml changes that accidentally made it early to master |
|
/lgtm |
|
the revert from service back to ip missed a couple of character changes: #5241 |
For issue #1038
removing the t.Skip()
Should fail in CI until we have a fix