Skip to content

fix incorrrect prometheus config #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2018
Merged

fix incorrrect prometheus config #5187

merged 3 commits into from
Apr 25, 2018

Conversation

rkpagadala
Copy link
Contributor

Cherry pick prometheus related changes, and fix setup cluster

@rkpagadala
remove prometheus from release archives (#5150)
ce3d006 
Automatic merge from submit-queue.

remove prometheus from release archives
@rkpagadala
fix path for go 1.10 on perf vm (#5168)
1f72f10
@rkpagadala rkpagadala requested review from ldemailly and hklai April 24, 2018 23:10
hklai
hklai approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title accordingly, and associate the issue with this PR.

/lgtm

@rkpagadala rkpagadala changed the title Release 0.8 fix incorrrect prometheus config Apr 24, 2018
@rkpagadala
Copy link
Contributor Author

fixes #5111

@ldemailly
Copy link
Member

/lgtm

@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #5187 into release-0.8 will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release-0.8   #5187   +/-   ##
===========================================
+ Coverage           73%     73%   +1%     
===========================================
  Files              313     313           
  Lines            26292   26333   +41     
===========================================
+ Hits             19134   19219   +85     
+ Misses            6388    6339   -49     
- Partials           770     775    +5
Impacted Files Coverage Δ
mixer/adapter/solarwinds/log_handler.go 50% <0%> (-7%) ⬇️
mixer/adapter/kubernetesenv/cache.go 83% <0%> (-6%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
mixer/adapter/prometheus/server.go 94% <0%> (-2%) ⬇️
mixer/adapter/rbac/rbac.go 10% <0%> (-1%) ⬇️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
mixer/adapter/denier/denier.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/keys.go 100% <0%> (ø) ⬆️
mixer/adapter/list/ipList.go 100% <0%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ef7e5...34d1e4b. Read the comment docs.

@ldemailly
Copy link
Member

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, ldemailly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@ldemailly ldemailly merged commit 7571546 into istio:release-0.8 Apr 25, 2018
@istio-testing
Copy link
Collaborator

istio-testing commented Apr 25, 2018 •
edited
Loading

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh 34d1e4b link /test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rkpagadala
Copy link
Contributor Author

docs fixes istio/istio.io#1199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldemailly ldemailly Awaiting requested review from ldemailly

1 more reviewer

@hklai hklai hklai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ldemailly ldemailly

@hklai hklai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rkpagadala @ldemailly @istio-testing @istio-merge-robot @hklai @googlebot