Skip to content

Cherry pick 5028 and 5124 (perf setup scripts update for kubecon) #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2018
Merged

Cherry pick 5028 and 5124 (perf setup scripts update for kubecon) #5147

merged 2 commits into from
Apr 24, 2018

Conversation

ldemailly
Copy link
Member

Cherry pick #5028 #5124

rkpagadala and others added 2 commits April 23, 2018 17:37
@rkpagadala @ldemailly
unset IFS, minor fix for perf setup (#5124)
6f89ed1 
Automatic merge from submit-queue.

unset IFS, minor fix for perf setup
@ldemailly
perf setup update: add grafana, misc fixes (#5028)
2f48a39 
* need git pull --tags to get latest_release movement, use DUR variable for duration

* Add grafana ingress

Doesn’t work because of mixer/telemetry split yet but almost

Also had to disable mtls for grafana - this should be the default

* Add annotation for no mtls in helm template

* From 0.8 prometheus is already in the yaml

See #5111
@ldemailly ldemailly requested a review from rkpagadala April 24, 2018 00:38
@ldemailly ldemailly changed the title Cherry pick 5028 5124 Cherry pick 5028 and 5124 (perf setup scripts update for kubecon) Apr 24, 2018
@ldemailly ldemailly requested review from ijsnellf and removed request for ijsnellf April 24, 2018 00:45
rkpagadala
rkpagadala approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@rkpagadala rkpagadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkpagadala
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog

Assign the PR to them by writing /assign @mandarjog in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit 156802b into release-0.8 Apr 24, 2018
@ldemailly ldemailly deleted the cherry-pick-5028-5124 branch April 24, 2018 01:02
@ldemailly
Copy link
Member Author

merged despite the ci2gubernator unrelated failures and need the fix for tomorrow's build

@istio-testing
Copy link
Collaborator

@ldemailly: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-bookInfoTests-v1alpha3.sh 2f48a39 link /test e2e-bookInfo-envoyv2-v1alpha3
prow/istio-pilot-e2e.sh 2f48a39 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rkpagadala rkpagadala rkpagadala approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rkpagadala rkpagadala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldemailly @istio-testing @rkpagadala @googlebot