Skip to content

envoy: bump github.com/envoyproxy/go-control-plane to main version #50562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2024
Merged

envoy: bump github.com/envoyproxy/go-control-plane to main version #50562

merged 5 commits into from
Apr 19, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 19, 2024 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

bump github.com/envoyproxy/go-control-plane to main version

This will also help confirm the modifications done in xds have no impact

@mmorel-35
envoy: bump github.com/envoyproxy/go-control-plane to main version
68ac17a 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@istio-policy-bot
Copy link

😊 Welcome @mmorel-35! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2024
@istio-testing
Copy link
Collaborator

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 19, 2024 •
edited
Loading

@adisuissa , @phlax, @howardjohn
This will answer your question from cncf/xds#93

@zirain
Copy link
Member

zirain commented Apr 19, 2024

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 19, 2024
@zirain
Copy link
Member

zirain commented Apr 19, 2024

Hope this will unblock my work before branch cutting.

@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Apr 19, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2024
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2024
@istio-testing istio-testing merged commit 730adec into istio:master Apr 19, 2024
@mmorel-35 mmorel-35 deleted the go-control-plane branch April 19, 2024 16:18
@adisuissa adisuissa mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@zirain zirain zirain approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@stevenctl stevenctl Awaiting requested review from stevenctl stevenctl is a code owner

@ericvn ericvn Awaiting requested review from ericvn

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu hzxuzhonghu is a code owner

Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorel-35 @istio-policy-bot @istio-testing @zirain @howardjohn