-
Notifications
You must be signed in to change notification settings - Fork 8.1k
add ip filter logic in GetProxyServiceTargets #48814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😊 Welcome @fatedier! This is either your first contribution to the Istio istio repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please add a release note
33b7d62
to
4c092cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, leave to @howardjohn
In response to a cherrypick label: #48814 failed to apply on top of branch "release-1.19":
|
In response to a cherrypick label: new pull request created: #48830 |
In response to a cherrypick label: new issue created for failed cherrypick: #48831 |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.20 from head istio-testing:cherry-pick-48814-to-release-1.20: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-48814-to-release-1.20."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
Please provide a description of this PR:
Fix #45241
Fix #48228