Skip to content

refactor e2e mixer tests #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2018
Merged

refactor e2e mixer tests #4678

merged 1 commit into from
Apr 4, 2018

Conversation

vadimeisenbergibm
Copy link
Contributor

based on #4185

@codecov
Copy link

codecov bot commented Apr 1, 2018 •
edited
Loading

Codecov Report

Merging #4678 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4678    +/-   ##
=======================================
- Coverage      75%     75%   -<1%     
=======================================
  Files         297     297            
  Lines       24760   24760            
=======================================
- Hits        18490   18487     -3     
- Misses       5505    5506     +1     
- Partials      765     767     +2
Impacted Files Coverage Δ
mixer/adapter/solarwinds/log_handler.go 58% <0%> (-11%) ⬇️
mixer/adapter/servicecontrol/reportprocessor.go 80% <0%> (-5%) ⬇️
mixer/adapter/servicecontrol/utils.go 90% <0%> (-1%) ⬇️
mixer/cmd/mixs/cmd/server.go 0% <0%> (ø) ⬆️
mixer/adapter/stdio/stdio.go 100% <0%> (ø) ⬆️
mixer/adapter/list/ipList.go 100% <0%> (ø) ⬆️
mixer/pkg/il/strings.go 100% <0%> (ø) ⬆️
mixer/adapter/prometheus/prometheus.go 100% <0%> (ø) ⬆️
mixer/adapter/stdio/zap.go 100% <0%> (ø) ⬆️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baad5ca...1a11ad0. Read the comment docs.

@sebastienvas
Copy link
Contributor

/approve

@vadimeisenbergibm
Copy link
Contributor Author

/retest

@vadimeisenbergibm
Copy link
Contributor Author

@sebastienvas it seems there is a bug in codecov. Once an untracked file is modified, code coverage shows 0 coverage and the test fails. Could you please merge the PR manually?

@sebastienvas
Copy link
Contributor

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sebastienvas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebastienvas sebastienvas merged commit 552cd9e into istio:master Apr 4, 2018
bianpengyuan pushed a commit to bianpengyuan/istio that referenced this pull request Apr 5, 2018
@vadimeisenbergibm @bianpengyuan
refactor e2e mixer tests (istio#4678)
2572eea 
based on istio#4185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douglas-reid douglas-reid Awaiting requested review from douglas-reid

1 more reviewer

@sebastienvas sebastienvas sebastienvas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sebastienvas sebastienvas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadimeisenbergibm @sebastienvas @istio-testing @googlebot