Skip to content

Add files for https service example with istio #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2018
Merged

Add files for https service example with istio #4663

merged 1 commit into from
Apr 2, 2018

Conversation

wattli
Copy link
Contributor

@wattli wattli commented Mar 30, 2018

This is used in istio/istio.io#1121

@wattli wattli requested review from myidpt and diemtvu March 30, 2018 18:28
myidpt
myidpt approved these changes Mar 31, 2018
View reviewed changes
Copy link

@myidpt myidpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@myidpt
Copy link

myidpt commented Mar 31, 2018

/lgtm

@myidpt
Copy link

myidpt commented Mar 31, 2018

/approve

@wattli wattli added the approved label Apr 2, 2018
@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: myidpt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-testing
Copy link
Collaborator

istio-testing commented Apr 2, 2018 •
edited
Loading

@wattli: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-e2e-v1alpha3.sh 388b610 link /test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit b0e0a31 into istio:master Apr 2, 2018
bianpengyuan pushed a commit to bianpengyuan/istio that referenced this pull request Apr 5, 2018
@wattli @bianpengyuan
Add files for https service example with istio (istio#4663)
d9e16d4 
Automatic merge from submit-queue.

Add files for https service example with istio

This is used in istio/istio.io#1121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemtvu diemtvu Awaiting requested review from diemtvu

1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@myidpt myidpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wattli @myidpt @istio-testing @istio-merge-robot @googlebot