Skip to content

[vendor-change] dep init + prune changes for 0.8 #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 30, 2018
Merged

[vendor-change] dep init + prune changes for 0.8 #4651

merged 16 commits into from
Mar 30, 2018

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Mar 30, 2018 •
edited
Loading

Fixes #4482

@ldemailly ldemailly changed the title dep init + prune changes for 0.8 [vendor-change] dep init + prune changes for 0.8 Mar 30, 2018
@ldemailly
Copy link
Member Author

matching vendor PR istio/old_vendor-istio_repo#45

@ldemailly ldemailly mentioned this pull request Mar 30, 2018
Merged
@ldemailly ldemailly requested a review from rshriram March 30, 2018 03:05
@ldemailly
Copy link
Member Author 

bin/gobuild.sh /Users/ldemailly/go/out/darwin_amd64/release/sidecar-injector istio.io/istio/pkg/version ./pilot/cmd/sidecar-injector
# istio.io/istio/vendor/k8s.io/kubernetes/pkg/util/parsers
vendor/k8s.io/kubernetes/pkg/util/parsers/parsers.go:36:16: undefined: reference.ParseNormalizedNamed

probably means I have the wrong github.com/docker/distribution/reference

@codecov
Copy link

codecov bot commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #4651 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4651    +/-   ##
=======================================
- Coverage      75%     75%   -<1%     
=======================================
  Files         297     297            
  Lines       24710   24638    -72     
=======================================
- Hits        18438   18369    -69     
+ Misses       5512    5508     -4     
- Partials      760     761     +1
Impacted Files Coverage Δ
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/stackdriver/stackdriver.go 64% <0%> (-6%) ⬇️
mixer/adapter/redisquota/redisquota.go 86% <0%> (-3%) ⬇️
pilot/pkg/model/authentication.go 77% <0%> (-3%) ⬇️
mixer/adapter/kubernetesenv/kubernetesenv.go 69% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/reportprocessor.go 79% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/quotaprocessor.go 83% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 63% <0%> (-1%) ⬇️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
mixer/adapter/prometheus/prometheus.go 100% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6349f14...9c3b7f7. Read the comment docs.

@ldemailly ldemailly changed the title [vendor-change] dep init + prune changes for 0.8 [vendor-change] dep init + prune changes for 0.8 + destination Name->Host (v1alpha3) Mar 30, 2018
@ldemailly
Copy link
Member Author

going to let someone from pilot fix this

@ldemailly ldemailly closed this Mar 30, 2018
@ldemailly ldemailly mentioned this pull request Mar 30, 2018
Closed
@ldemailly ldemailly reopened this Mar 30, 2018
@ldemailly ldemailly changed the title [vendor-change] dep init + prune changes for 0.8 + destination Name->Host (v1alpha3) [vendor-change] dep init + prune changes for 0.8 Mar 30, 2018
@ldemailly ldemailly requested review from kyessenov and removed request for rshriram March 30, 2018 21:38
@kyessenov
Copy link
Contributor

/lgtm
/approve

kyessenov
kyessenov reviewed Mar 30, 2018
View reviewed changes
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rlenglet: this should bring the go-control-plane updat to istio.

This was referenced Mar 30, 2018
Merged
Merged
@ldemailly
Copy link
Member Author

mixer failure is unrelated readiness issue

prow is overloaded

will merge

@kyessenov
Copy link
Contributor

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli

Assign the PR to them by writing /assign @wattli in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@ldemailly ldemailly merged commit 9e64e71 into master Mar 30, 2018
@ldemailly ldemailly deleted the dep_reset_0_8 branch March 30, 2018 23:04
bianpengyuan pushed a commit to bianpengyuan/istio that referenced this pull request Apr 5, 2018
@ldemailly @bianpengyuan
[vendor-change] dep init + prune changes for 0.8 (istio#4651)
b4f8772 
* dep init + prune changes for 0.8

* dep init + prune changes for 0.8 - try#2 with k8s 1.9 instead of 1.10

* start of changes for istio/api#439 - will continue on my mac

* Rest of fixes for Name->Host

Matching istio/api#439

* Compiling!

* More Name->Host fun

* Use our glog

* Make go generate ./mixer/... runnable

* Partial fix for name->host

* Update back api

* Revert destination name->host

* need fortio to be buildable from vendor, grpc health is a dependency

* switching vendor to master post istio/old_vendor-istio_repo#45 merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov approved these changes

Assignees

@kyessenov kyessenov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldemailly @kyessenov @istio-testing @googlebot