Skip to content

[Test Framework] Fix incorrect duration in log #46404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2023
Merged

[Test Framework] Fix incorrect duration in log #46404

merged 1 commit into from
Aug 9, 2023

Conversation

Abirdcfly
Copy link
Member

@Abirdcfly Abirdcfly commented Aug 9, 2023 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
The deferred call's arguments are evaluated immediately, but the function call is not executed until the surrounding function returns.

see example in https://go.dev/play/p/cyhhUBcZUJj

@Abirdcfly
[Test Framework] Fix incorrect duration in log
e749aa7 
The deferred call's arguments are evaluated immediately, but the function call is not executed until the surrounding function returns.
@Abirdcfly Abirdcfly requested a review from a team as a code owner August 9, 2023 02:03
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot istio-policy-bot added area/test and release release-notes-none Indicates a PR that does not require release notes. labels Aug 9, 2023
@istio-policy-bot
Copy link

😊 Welcome @Abirdcfly! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Aug 9, 2023
@istio-testing
Copy link
Collaborator

Hi @Abirdcfly. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hanxiaop
Copy link
Member

hanxiaop commented Aug 9, 2023

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 9, 2023
@Abirdcfly
Copy link
Member Author

And maybe this issue is helpful: golang/go#60048

@istio-testing istio-testing merged commit bc8f137 into istio:master Aug 9, 2023
@Abirdcfly Abirdcfly deleted the fixdefer branch August 10, 2023 06:22
@Abirdcfly Abirdcfly mentioned this pull request Aug 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
area/test and release ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Abirdcfly @istio-policy-bot @istio-testing @hanxiaop @howardjohn