Skip to content

Set integer seconds for CORS max age #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 19, 2018
Merged

Set integer seconds for CORS max age #4324

merged 4 commits into from
Mar 19, 2018
+6 −6

Conversation

ijsnellf
Copy link
Contributor

@ijsnellf ijsnellf commented Mar 16, 2018 •
edited
Loading

This was never set correctly. It should be integer seconds, not Go duration strings (2m5s, etc): https://www.w3.org/TR/cors/#access-control-max-age-response-header

@ijsnellf ijsnellf requested review from rshriram and GregHanson March 16, 2018 15:24
@ijsnellf ijsnellf mentioned this pull request Mar 16, 2018
Merged
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: qiwzhang

Assign the PR to them by writing /assign @qiwzhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 16, 2018 •
edited
Loading

Codecov Report

Merging #4324 into master will decrease coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4324    +/-   ##
=======================================
- Coverage      71%     70%   -<1%     
=======================================
  Files         315     315            
  Lines       29042   28981    -61     
=======================================
- Hits        20360   20265    -95     
- Misses       7462    7489    +27     
- Partials     1220    1227     +7
Impacted Files Coverage Δ
pilot/pkg/proxy/envoy/v1/resources.go 81% <ø> (ø) ⬆️
pilot/pkg/proxy/envoy/v1/route.go 95% <100%> (ø) ⬆️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/solarwinds/log_handler.go 50% <0%> (-7%) ⬇️
mixer/adapter/servicecontrol/handler.go 39% <0%> (-7%) ⬇️
mixer/adapter/redisquota/redisquota.go 86% <0%> (-3%) ⬇️
mixer/adapter/prometheus/server.go 97% <0%> (-3%) ⬇️
mixer/adapter/prometheus/prometheus.go 86% <0%> (-3%) ⬇️
pilot/pkg/model/egress_rules.go 95% <0%> (-2%) ⬇️
mixer/adapter/kubernetesenv/cache.go 83% <0%> (-1%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94f090...a398033. Read the comment docs.

@kyessenov kyessenov self-requested a review March 16, 2018 20:27
@rshriram rshriram closed this Mar 17, 2018
@rshriram rshriram reopened this Mar 17, 2018
@rshriram rshriram merged commit 367c360 into istio:master Mar 19, 2018
@ijsnellf ijsnellf deleted the fix-cors-max-age branch June 4, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov approved these changes

@GregHanson GregHanson Awaiting requested review from GregHanson

+1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ijsnellf @istio-merge-robot @rshriram @kyessenov @googlebot