Refactor ambient CNI informer #42012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves a few things: * Bug: when a new ztunnel spins up, we mark it as active. Then the old one spins down, and we mark ztunnelReady=false, ignoring the new one. Now, we reconcile the state to get the "active" ztunnel reliably * Performance: tune informers to only watch things on our node, rather than everything * Style: use a single Reconcile() function instead of 1 queue and 1 pod handler Unfortunately, there are no unit tests for this; the code here to configuer ipset, etc is not abstracted in a testable way currently. I did manually test and the e2e tests pass, however. Long term we should improve this, but this code may be going away soon anyways
dhawton
approved these changes
Nov 15, 2022
|
/test integ-cni |
|
I think its a real bug, not sure what though. looking into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a few things:
Unfortunately, there are no unit tests for this; the code here to configuer ipset, etc is not abstracted in a testable way currently. I did manually test and the e2e tests pass, however. Long term we should improve this, but this code may be going away soon anyways
Please provide a description of this PR: