Skip to content

[release-1.17] Use helm repo for integration tests instead of tarballs #42972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 25, 2023
Merged

[release-1.17] Use helm repo for integration tests instead of tarballs #42972

merged 5 commits into from
Jan 25, 2023

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #42864

@kfaseela @istio-testing
Use helm repo for integration tests instead of tarballs
3ab4760 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela @istio-testing
refactor
6729ca1 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela @istio-testing
configuration option for helm repo
02dd61b 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela @istio-testing
fix lint failure
fa043f9 
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela @istio-testing
add --repo to individual commands
ed69bf1 
Signed-off-by: Faseela K <faseela.k@est.tech>
@istio-testing istio-testing requested a review from a team January 24, 2023 18:20
@istio-testing istio-testing mentioned this pull request Jan 24, 2023
Merged
@istio-testing istio-testing added release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2023
@ericvn
Copy link
Contributor

ericvn commented Jan 24, 2023

/retest

@kfaseela
Copy link
Member

@ericvn @johnma14 planning to get this in for 1.17? This would be needed if we would like to have Helm Promotion to Beta in 1.17

johnma14
johnma14 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@johnma14 johnma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are mostly to the integration test framework. LGTM for 1.17

@kfaseela
Copy link
Member

Changes are mostly to the integration test framework. LGTM for 1.17

Thanks @johnma14 ! @pmerrison might have to approve as well.

@istio-testing istio-testing merged commit face5ef into istio:release-1.17 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@johnma14 johnma14 johnma14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@istio-testing @ericvn @kfaseela @johnma14