Skip to content

add e2e for MetricDefinition (#42563) #42924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

add e2e for MetricDefinition (#42563) #42924

merged 1 commit into from
Jan 20, 2023

Conversation

kyessenov
Copy link
Contributor

No description provided.

@kyessenov
add e2e for MetricDefinition (istio#42563)
188551e 
* add e2e for MetricDefinition

* fix lint

* send http traffic only

* fix prom query
@kyessenov kyessenov requested a review from a team January 20, 2023 19:31
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2023
@kyessenov kyessenov added the release-notes-none Indicates a PR that does not require release notes. label Jan 20, 2023
@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

Crash present:

2023-01-20T19:52:18.253932Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:104	Caught Segmentation fault, suspect faulting address 0x0	thread=216
2023-01-20T19:52:18.276450Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:91	Backtrace (use tools/stack_decode.py to get line numbers):	thread=216
2023-01-20T19:52:18.276474Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:92	Envoy version: 7424dcd0b7931cfc550776ed2824a50e61fba50c/1.26.0-dev/Clean/RELEASE/BoringSSL	thread=216
2023-01-20T19:52:18.277120Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:98	#0: [0x7fbdb3488520]	thread=216
2023-01-20T19:52:19.554674Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:96	#1: event_base_loop [0x564ab8e8da01]	thread=216
2023-01-20T19:52:21.021456Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:96	#2: Envoy::Server::InstanceImpl::run() [0x564ab836b91b]	thread=216
2023-01-20T19:52:23.988662Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:96	#3: Envoy::MainCommonBase::run() [0x564ab6d246f4]	thread=216
2023-01-20T19:52:25.136870Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:96	#4: Envoy::MainCommon::main() [0x564ab6d24f76]	thread=216
2023-01-20T19:52:26.363048Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:96	#5: main [0x564ab6d2252c]	thread=216
2023-01-20T19:52:26.363434Z	critical	envoy backtrace external/envoy/source/server/backtrace.h:98	#6: [0x7fbdb346fd90]	thread=216

But this is not related to metric definition. Will need further investigation for security-multicluster-istio @lei-tang

@howardjohn
Copy link
Member

That is the one I have been trying to debug but have been blocked due to debug builds failing for other reasons

@kyessenov
Copy link
Contributor Author

@howardjohn #41470 was very effective in triage of the stats crash. Authz tests are superflakey with Asan because of hard coded time outs. We should adjust timeouts, bump memory, and will get proper trace out.

@kyessenov
Copy link
Contributor Author

Shouldn't we block the release until we know why Envoy crashes sometimes? Once this code makes it production, it'll be near impossible to diagnose intermittent crashes without managed proxies.

@istio-testing istio-testing merged commit 40a7bea into istio:master Jan 20, 2023
bleggett added a commit to bleggett/istio that referenced this pull request Jan 24, 2023
@bleggett
Add basic integration tests for PROXY protocol and gateway
c8c4b28 
Update protobufs

Add dep

Derp

Consider actually using TCP

Hmm

Fix this

Missed one

Add log message

Logging

Remove these

Testing

Missed this

gawd

Hmm

Fix this

Testing

Ugh

Whitespace

Testing

Invalid component

Testing

Fix logging

Testt

Add alt case

Hmm

Fix

Fix 2

Fix routing

Actually fix

Fix this

Don't cleanup gateways

Aight

I'm a goofus

Tidy

Testing

Test

Hmm

Test

Fix this

Hmmm

Oh

Fix this

Fix this

test

Hmm

Test

Hmm

Hmm

Cleanup

Revert "Cleanup"

This reverts commit 1f933b720c504dc82cdb5683e1e08e6d464f5f1a.

Fix this

Better comment

Fix comment

Automator: update proxy@master in istio/istio@master (istio#42865)

Automator: update common-files@master in istio/istio@master (istio#42879)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42880)

improve wasm ecds comments (istio#42883)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Change no server certificate verify as warning level (istio#42876)

* Change no server certificate verify as warning level

* update

Use latest helm dependency (istio#42891)

Automator: update proxy@master in istio/istio@master (istio#42898)

Automator: update common-files@master in istio/istio@master (istio#42900)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42901)

Automator: update proxy@master in istio/istio@master (istio#42907)

Cleanup unused metadata (istio#42903)

Update BASE_VERSION to master-2023-01-20T04-29-21 (istio#42913)

Add Locality info to debug interface (istio#42884)

Switching revision in IstioOperator istio-gateway cache fix (istio#42529)

* switching revision in IstioOperator istio-gateway cache fix

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

* include all components

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Automator: update proxy@master in istio/istio@master (istio#42923)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42926)

add e2e for MetricDefinition (istio#42563) (istio#42924)

* add e2e for MetricDefinition

* fix lint

* send http traffic only

* fix prom query

Co-authored-by: zirain <hejianpeng2@huawei.com>

tf: ensure Check is always set (istio#42908)

* tf: ensure Check is always set

Avoid cases where we do not test anything

* Always set

* a few more

* fix

Initial messing about for PROXY protocol tests

Fix this

Automator: update proxy@master in istio/istio@master (istio#42865)

Automator: update common-files@master in istio/istio@master (istio#42879)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42880)

improve wasm ecds comments (istio#42883)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Change no server certificate verify as warning level (istio#42876)

* Change no server certificate verify as warning level

* update

Use latest helm dependency (istio#42891)

Automator: update proxy@master in istio/istio@master (istio#42898)

Automator: update common-files@master in istio/istio@master (istio#42900)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42901)

Automator: update proxy@master in istio/istio@master (istio#42907)

Cleanup unused metadata (istio#42903)

Update BASE_VERSION to master-2023-01-20T04-29-21 (istio#42913)

Add Locality info to debug interface (istio#42884)

Switching revision in IstioOperator istio-gateway cache fix (istio#42529)

* switching revision in IstioOperator istio-gateway cache fix

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

* include all components

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Automator: update proxy@master in istio/istio@master (istio#42923)

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42926)

add e2e for MetricDefinition (istio#42563) (istio#42924)

* add e2e for MetricDefinition

* fix lint

* send http traffic only

* fix prom query

Co-authored-by: zirain <hejianpeng2@huawei.com>

tf: ensure Check is always set (istio#42908)

* tf: ensure Check is always set

Avoid cases where we do not test anything

* Always set

* a few more

* fix

wasm: Send nack when there is not well-formed resource messages (istio#42928)

* Send nack when there is an unmarshal error.

Change-Id: I8143ba8bc8c292ce2de5abda0a4f0c70c111bf80

* change if structure to have more readability

Change-Id: I076929d14dd1312b3717fe992352520223997354

* add unit tests

Change-Id: I31831ea1ba87c99ffc0451a7f3a2cb02acc14d91

Automator: update proxy@master in istio/istio@master (istio#42931)

Automator: update go dependencies@ in istio/istio@master (istio#42932)

Fix TestDeltaEDS flake (istio#42925)

improve appsv1 package import statement (istio#42946)

Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>

Use the slices package for contains check (istio#42947)

Automator: update common-files@master in istio/istio@master (istio#42948)

reducing leaseduration, renewdeadline and retryperiod to shorten test time (istio#42920)

add patch name to envoy filter crash log line (istio#42935)

* add patch name to envoy filter crash log line

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

* log line change

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

use authn filter constant every where (istio#42936)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Automator: update istio/client-go@master dependency in istio/istio@master (istio#42949)

Automator: update proxy@master in istio/istio@master (istio#42950)

Automator: update proxy@master in istio/istio@master (istio#42953)

Update master branch from 1.17 to 1.18 (istio#42875)

* Update master branch from 1.17 to 1.18

* Remove older envoy filters

* Fixup some version errors

Update default k8s for test and buildkit (istio#42952)

Use helm repo for integration tests instead of tarballs (istio#42864)

* Use helm repo for integration tests instead of tarballs

Signed-off-by: Faseela K <faseela.k@est.tech>

* refactor

Signed-off-by: Faseela K <faseela.k@est.tech>

* configuration option for helm repo

Signed-off-by: Faseela K <faseela.k@est.tech>

* fix lint failure

Signed-off-by: Faseela K <faseela.k@est.tech>

* add --repo to individual commands

Signed-off-by: Faseela K <faseela.k@est.tech>

Signed-off-by: Faseela K <faseela.k@est.tech>

Automator: update common-files@master in istio/istio@master (istio#42957)
istio-testing pushed a commit that referenced this pull request Jan 31, 2023
@bleggett @linsun
Add some basic proxy protocol tests (#42962)
a306e4c 
* Test

* Add basic integration tests for PROXY protocol and gateway

Update protobufs

Add dep

Derp

Consider actually using TCP

Hmm

Fix this

Missed one

Add log message

Logging

Remove these

Testing

Missed this

gawd

Hmm

Fix this

Testing

Ugh

Whitespace

Testing

Invalid component

Testing

Fix logging

Testt

Add alt case

Hmm

Fix

Fix 2

Fix routing

Actually fix

Fix this

Don't cleanup gateways

Aight

I'm a goofus

Tidy

Testing

Test

Hmm

Test

Fix this

Hmmm

Oh

Fix this

Fix this

test

Hmm

Test

Hmm

Hmm

Cleanup

Revert "Cleanup"

This reverts commit 1f933b720c504dc82cdb5683e1e08e6d464f5f1a.

Fix this

Better comment

Fix comment

Automator: update proxy@master in istio/istio@master (#42865)

Automator: update common-files@master in istio/istio@master (#42879)

Automator: update istio/client-go@master dependency in istio/istio@master (#42880)

improve wasm ecds comments (#42883)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Change no server certificate verify as warning level (#42876)

* Change no server certificate verify as warning level

* update

Use latest helm dependency (#42891)

Automator: update proxy@master in istio/istio@master (#42898)

Automator: update common-files@master in istio/istio@master (#42900)

Automator: update istio/client-go@master dependency in istio/istio@master (#42901)

Automator: update proxy@master in istio/istio@master (#42907)

Cleanup unused metadata (#42903)

Update BASE_VERSION to master-2023-01-20T04-29-21 (#42913)

Add Locality info to debug interface (#42884)

Switching revision in IstioOperator istio-gateway cache fix (#42529)

* switching revision in IstioOperator istio-gateway cache fix

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

* include all components

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Automator: update proxy@master in istio/istio@master (#42923)

Automator: update istio/client-go@master dependency in istio/istio@master (#42926)

add e2e for MetricDefinition (#42563) (#42924)

* add e2e for MetricDefinition

* fix lint

* send http traffic only

* fix prom query

Co-authored-by: zirain <hejianpeng2@huawei.com>

tf: ensure Check is always set (#42908)

* tf: ensure Check is always set

Avoid cases where we do not test anything

* Always set

* a few more

* fix

Initial messing about for PROXY protocol tests

Fix this

Automator: update proxy@master in istio/istio@master (#42865)

Automator: update common-files@master in istio/istio@master (#42879)

Automator: update istio/client-go@master dependency in istio/istio@master (#42880)

improve wasm ecds comments (#42883)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Change no server certificate verify as warning level (#42876)

* Change no server certificate verify as warning level

* update

Use latest helm dependency (#42891)

Automator: update proxy@master in istio/istio@master (#42898)

Automator: update common-files@master in istio/istio@master (#42900)

Automator: update istio/client-go@master dependency in istio/istio@master (#42901)

Automator: update proxy@master in istio/istio@master (#42907)

Cleanup unused metadata (#42903)

Update BASE_VERSION to master-2023-01-20T04-29-21 (#42913)

Add Locality info to debug interface (#42884)

Switching revision in IstioOperator istio-gateway cache fix (#42529)

* switching revision in IstioOperator istio-gateway cache fix

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

* include all components

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Signed-off-by: Shubham Chauhan <shubham@tetrate.io>

Automator: update proxy@master in istio/istio@master (#42923)

Automator: update istio/client-go@master dependency in istio/istio@master (#42926)

add e2e for MetricDefinition (#42563) (#42924)

* add e2e for MetricDefinition

* fix lint

* send http traffic only

* fix prom query

Co-authored-by: zirain <hejianpeng2@huawei.com>

tf: ensure Check is always set (#42908)

* tf: ensure Check is always set

Avoid cases where we do not test anything

* Always set

* a few more

* fix

wasm: Send nack when there is not well-formed resource messages (#42928)

* Send nack when there is an unmarshal error.

Change-Id: I8143ba8bc8c292ce2de5abda0a4f0c70c111bf80

* change if structure to have more readability

Change-Id: I076929d14dd1312b3717fe992352520223997354

* add unit tests

Change-Id: I31831ea1ba87c99ffc0451a7f3a2cb02acc14d91

Automator: update proxy@master in istio/istio@master (#42931)

Automator: update go dependencies@ in istio/istio@master (#42932)

Fix TestDeltaEDS flake (#42925)

improve appsv1 package import statement (#42946)

Signed-off-by: xin.li <xin.li@daocloud.io>

Signed-off-by: xin.li <xin.li@daocloud.io>

Use the slices package for contains check (#42947)

Automator: update common-files@master in istio/istio@master (#42948)

reducing leaseduration, renewdeadline and retryperiod to shorten test time (#42920)

add patch name to envoy filter crash log line (#42935)

* add patch name to envoy filter crash log line

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

* log line change

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

use authn filter constant every where (#42936)

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

Automator: update istio/client-go@master dependency in istio/istio@master (#42949)

Automator: update proxy@master in istio/istio@master (#42950)

Automator: update proxy@master in istio/istio@master (#42953)

Update master branch from 1.17 to 1.18 (#42875)

* Update master branch from 1.17 to 1.18

* Remove older envoy filters

* Fixup some version errors

Update default k8s for test and buildkit (#42952)

Use helm repo for integration tests instead of tarballs (#42864)

* Use helm repo for integration tests instead of tarballs

Signed-off-by: Faseela K <faseela.k@est.tech>

* refactor

Signed-off-by: Faseela K <faseela.k@est.tech>

* configuration option for helm repo

Signed-off-by: Faseela K <faseela.k@est.tech>

* fix lint failure

Signed-off-by: Faseela K <faseela.k@est.tech>

* add --repo to individual commands

Signed-off-by: Faseela K <faseela.k@est.tech>

Signed-off-by: Faseela K <faseela.k@est.tech>

Automator: update common-files@master in istio/istio@master (#42957)

* Fix these

* Lint fixes

* Fix comments

* Lint fixes

* More lint fixes

* Be slightly more efficient with gateway creation

* Lints

* Update tests/integration/pilot/common/routing.go

Co-authored-by: Lin Sun <lin.sun@solo.io>

---------

Co-authored-by: Lin Sun <lin.sun@solo.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@lei-tang lei-tang lei-tang approved these changes

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyessenov @howardjohn @lei-tang @istio-testing