Add CODEOWNERS for ambient #41384
Merged
Add CODEOWNERS for ambient #41384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See istio/test-infra#4322 The intent here is not so much to make only these folks able to approve PRs, but to stop requesting reviews from the WGs on ambient PRs (which they may not care about). Instead, only the folks interested in ambient should get spammed. I picked the people based on top # of commits. I have no problem adding others
|
I see a message: Maybe Yuval will will become a member/maintainer at some point. |
|
Thanks, I will drop them then |
ericvn
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See istio/test-infra#4322
The intent here is not so much to make only these folks able to approve PRs, but to stop requesting reviews from the WGs on ambient PRs (which they may not care about). Instead, only the folks interested in ambient should get spammed.
I picked the people based on top # of commits. I have no problem adding others