Skip to content

Change memory config map to sync.Map #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2018
Merged

Change memory config map to sync.Map #4137

merged 2 commits into from
Mar 10, 2018

Conversation

xiaolanz
Copy link
Contributor

@xiaolanz xiaolanz commented Mar 9, 2018

address race condition to access the map. #4041

@xiaolanz xiaolanz requested review from nmittler, kyessenov and a team March 9, 2018 08:39
@xiaolanz xiaolanz requested a review from ayj March 9, 2018 17:30
ayj
ayj approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@ayj ayj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayj

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 9, 2018 •
edited
Loading

Codecov Report

Merging #4137 into master will decrease coverage by 1%.
The diff coverage is 92%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4137    +/-   ##
=======================================
- Coverage      73%     73%   -<1%     
=======================================
  Files         313     313            
  Lines       28829   28730    -99     
=======================================
- Hits        20936   20847    -89     
+ Misses       6570    6558    -12     
- Partials     1323    1325     +2
Impacted Files Coverage Δ
pilot/pkg/config/memory/config.go 98% <92%> (-2%) ⬇️
pilot/pkg/model/conversion.go 86% <0%> (-2%) ⬇️
mixer/adapter/servicecontrol/quotaprocessor.go 83% <0%> (-1%) ⬇️
mixer/adapter/circonus/circonus.go 70% <0%> (-1%) ⬇️
pilot/pkg/proxy/envoy/v2/mesh.go 75% <0%> (ø) ⬇️
mixer/adapter/prometheus/server.go 96% <0%> (ø) ⬇️
mixer/adapter/redisquota/redisquota.go 90% <0%> (ø) ⬇️
mixer/adapter/fluentd/fluentd.go 76% <0%> (ø) ⬇️
mixer/adapter/list/list.go 100% <0%> (ø) ⬇️
mixer/adapter/denier/denier.go 93% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7752f...34c2548. Read the comment docs.

@istio-merge-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @ayj @xiaolanz

@xiaolanz
Copy link
Contributor Author

xiaolanz commented Mar 9, 2018

/retest

@xiaolanz xiaolanz merged commit 7b089fa into istio:master Mar 10, 2018
sebastienvas added a commit that referenced this pull request Mar 10, 2018
@sebastienvas
Revert "Change memory config map to sync.Map (#4137)"
5aeaeda 
This reverts commit 7b089fa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmittler nmittler Awaiting requested review from nmittler

@kyessenov kyessenov Awaiting requested review from kyessenov

1 more reviewer

@ayj ayj ayj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ayj ayj

Labels
area/test and release kind/test failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiaolanz @istio-merge-robot @ayj @googlebot @istio-testing