make: use more portable syntax for STDERR redirect to keep OSX happy #4130

ZackButcher · 2018-03-09T01:58:45Z

chxchx · 2018-03-09T02:01:46Z

Makefile

@@ -415,7 +415,7 @@ test: | $(JUNIT_REPORT)
 	mkdir -p $(dir $(JUNIT_UNIT_TEST_XML))
 	set -o pipefail; \
 	$(MAKE) --keep-going pilot-test mixer-test security-test broker-test galley-test common-test \
-	|& tee >($(JUNIT_REPORT) > $(JUNIT_UNIT_TEST_XML))
+	2>&1 tee >($(JUNIT_REPORT) > $(JUNIT_UNIT_TEST_XML))


You still need the pipe tho
2>&1 | tee >($(JUNIT_REPORT) > $(JUNIT_UNIT_TEST_XML))

whoops, thanks.

codecov · 2018-03-09T02:22:44Z

Codecov Report

Merging #4130 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4130    +/-   ##
=======================================
- Coverage      75%     75%   -<1%     
=======================================
  Files         305     305            
  Lines       27845   27824    -21     
=======================================
- Hits        20852   20790    -62     
- Misses       5664    5716    +52     
+ Partials     1329    1318    -11

Impacted Files	Coverage Δ
mixer/adapter/redisquota/redisquota.go	`86% <0%> (-3%)`	⬇️
security/pkg/registry/kube/service.go	`60% <0%> (-3%)`	⬇️
pilot/pkg/model/conversion.go	`86% <0%> (-2%)`	⬇️
pilot/pkg/config/kube/crd/controller.go	`77% <0%> (-1%)`	⬇️
mixer/adapter/servicecontrol/reportbuilder.go	`89% <0%> (ø)`	⬇️
mixer/adapter/circonus/circonus.go	`71% <0%> (ø)`	⬇️
mixer/adapter/list/regexList.go	`100% <0%> (ø)`	⬆️
mixer/adapter/dogstatsd/dogstatsd.go	`100% <0%> (ø)`	⬆️
pilot/pkg/serviceregistry/kube/controller.go	`69% <0%> (ø)`	⬆️
pkg/probe/client.go	`100% <0%> (ø)`	⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8229fc...6200ba3. Read the comment docs.

ldemailly · 2018-03-09T02:27:04Z

/lgtm

ZackButcher · 2018-03-09T02:27:25Z

/retest

ZackButcher · 2018-03-09T02:27:42Z

I'd really like to see at least the unit tests pass on prow...

istio-merge-robot · 2018-03-09T02:27:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

ZackButcher · 2018-03-09T02:43:15Z

(waiting to see which prow things fail before submitting)

istio-merge-robot · 2018-03-09T02:44:00Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-testing · 2018-03-09T03:12:28Z

@ZackButcher: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/istio-unit-tests.sh	`6200ba3`	link	`/test istio-unit-tests`
prow/e2e-simpleTests.sh	`6200ba3`	link	`/test e2e-simple`
prow/e2e-bookInfoTests.sh	`6200ba3`	link	`/test e2e-bookInfo`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: 2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (istio#1939) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (istio#4190) 36809d80a fuzz: coverage profile generation instructions. (istio#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075) 05c0d52d3 build: use clang-6.0. (istio#4168) 01f403ec4 thrift_proxy: introduce header transport (istio#4082) 564d256fb tcp: allow connection pool callers to store protocol state (istio#4131) 3e1d643b9 configs: match latest API changes (istio#4185) bc6a10c2f Fix wrong mock function name. (istio#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182) 3d1325e89 Converting envoy configs to V2 (istio#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157) 71152b710 ratelimit: Add ratelimit custom response headers (istio#4015) 306287418 ssl: make Ssl::Connection const everywhere (istio#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130) 8c189a552 Make over provisioning factor configurable (istio#4003) 6c08fb43c Making test less flaky (istio#4149) 592775b7b fuzz: bare bones HCM fuzzer. (istio#4118) For istio#7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (istio#1938) a32a587 Add a check cache test for string map sub keys (istio#1931) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (istio#4190) 36809d80a fuzz: coverage profile generation instructions. (istio#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075) 05c0d52d3 build: use clang-6.0. (istio#4168) 01f403ec4 thrift_proxy: introduce header transport (istio#4082) 564d256fb tcp: allow connection pool callers to store protocol state (istio#4131) 3e1d643b9 configs: match latest API changes (istio#4185) bc6a10c2f Fix wrong mock function name. (istio#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182) 3d1325e89 Converting envoy configs to V2 (istio#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157) 71152b710 ratelimit: Add ratelimit custom response headers (istio#4015) 306287418 ssl: make Ssl::Connection const everywhere (istio#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130) 8c189a552 Make over provisioning factor configurable (istio#4003) 6c08fb43c Making test less flaky (istio#4149) 592775b7b fuzz: bare bones HCM fuzzer. (istio#4118) For istio#7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

…). (#8161) This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: 2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (#1939) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (#4190) 36809d80a fuzz: coverage profile generation instructions. (#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (#4075) 05c0d52d3 build: use clang-6.0. (#4168) 01f403ec4 thrift_proxy: introduce header transport (#4082) 564d256fb tcp: allow connection pool callers to store protocol state (#4131) 3e1d643b9 configs: match latest API changes (#4185) bc6a10c2f Fix wrong mock function name. (#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182) 3d1325e89 Converting envoy configs to V2 (#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157) 71152b710 ratelimit: Add ratelimit custom response headers (#4015) 306287418 ssl: make Ssl::Connection const everywhere (#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (#4130) 8c189a552 Make over provisioning factor configurable (#4003) 6c08fb43c Making test less flaky (#4149) 592775b7b fuzz: bare bones HCM fuzzer. (#4118) For #7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (#1938) a32a587 Add a check cache test for string map sub keys (#1931) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (#4190) 36809d80a fuzz: coverage profile generation instructions. (#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (#4075) 05c0d52d3 build: use clang-6.0. (#4168) 01f403ec4 thrift_proxy: introduce header transport (#4082) 564d256fb tcp: allow connection pool callers to store protocol state (#4131) 3e1d643b9 configs: match latest API changes (#4185) bc6a10c2f Fix wrong mock function name. (#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182) 3d1325e89 Converting envoy configs to V2 (#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157) 71152b710 ratelimit: Add ratelimit custom response headers (#4015) 306287418 ssl: make Ssl::Connection const everywhere (#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (#4130) 8c189a552 Make over provisioning factor configurable (#4003) 6c08fb43c Making test less flaky (#4149) 592775b7b fuzz: bare bones HCM fuzzer. (#4118) For #7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

use more portable syntax for STDERR redirect to keep OSX happy

dd5ea41

ZackButcher requested review from chxchx and a team March 9, 2018 01:58

googlebot added the cla: yes label Mar 9, 2018

ZackButcher requested a review from andraxylia March 9, 2018 01:58

chxchx reviewed Mar 9, 2018

View reviewed changes

pipe

6200ba3

ldemailly approved these changes Mar 9, 2018

View reviewed changes

istio-testing assigned ldemailly Mar 9, 2018

istio-testing added the lgtm label Mar 9, 2018

istio-merge-robot added the approved label Mar 9, 2018

douglas-reid added the kind/fixit label Mar 9, 2018

ZackButcher merged commit d11a422 into istio:master Mar 9, 2018

This was referenced Aug 23, 2018

Update Proxy SHA to latest with MetricImpl optimizations. #8160

Merged

Update Proxy SHA to latest with MetricImpl optimizations (release-1.0). #8161

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

make: use more portable syntax for STDERR redirect to keep OSX happy #4130

make: use more portable syntax for STDERR redirect to keep OSX happy #4130

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

chxchx Mar 9, 2018

Uh oh!

ZackButcher Mar 9, 2018

Uh oh!

codecov bot commented Mar 9, 2018 •

edited

Loading

Uh oh!

ldemailly commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

istio-merge-robot commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

istio-merge-robot commented Mar 9, 2018

Uh oh!

istio-testing commented Mar 9, 2018 •

edited

Loading

Uh oh!

Uh oh!

make: use more portable syntax for STDERR redirect to keep OSX happy #4130

make: use more portable syntax for STDERR redirect to keep OSX happy #4130

Uh oh!

Conversation

ZackButcher commented Mar 9, 2018

Uh oh!

chxchx Mar 9, 2018

Choose a reason for hiding this comment

Uh oh!

ZackButcher Mar 9, 2018

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ldemailly commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

istio-merge-robot commented Mar 9, 2018

Uh oh!

ZackButcher commented Mar 9, 2018

Uh oh!

istio-merge-robot commented Mar 9, 2018

Uh oh!

istio-testing commented Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 9, 2018 •

edited

Loading

istio-testing commented Mar 9, 2018 •

edited

Loading