Skip to content

[release-1.14] cherrypick for "istioctl x ps --xds-via-agents" #41056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2022
Merged

[release-1.14] cherrypick for "istioctl x ps --xds-via-agents" #41056

merged 3 commits into from
Sep 19, 2022

Conversation

ingwonsong
Copy link
Contributor

ingwonsong and others added 3 commits September 19, 2022 18:51
@ingwonsong
Send only the Cluster ID (istio#40477)
4be6905
@ingwonsong
Add Tap gRPC handler to Istio Agent. (istio#40566)
efebf29 
* Add Tap GRPC handler to Istio Agent.

* Fix lint errors

* Add the integration test
@ingwonsong @howardjohn
istioctl x proxy-status via istio agents. (istio#40623)
e348940 
* `istioctl ps` via istio agents.

* Fix lint errors

* Fix lint errors

* Use k8s client_go instead of RESTClient

* Update pkg/kube/client.go

Co-authored-by: John Howard <howardjohn@google.com>

* Use constant for "status.phase=Running"

* Use the revision in the annotation instead of labels for the injected pods

* Add xds-via-agents-limit flag

* Reflect the comments and refactoring

Co-authored-by: John Howard <howardjohn@google.com>
@ingwonsong ingwonsong requested a review from a team September 19, 2022 18:56
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2022
@ingwonsong ingwonsong added the release-notes-none Indicates a PR that does not require release notes. label Sep 19, 2022
@ingwonsong
Copy link
Contributor Author

/retest

@istio-testing istio-testing merged commit 73ac2f7 into istio:release-1.14 Sep 19, 2022
@ingwonsong ingwonsong mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@GregHanson GregHanson GregHanson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingwonsong @GregHanson @istio-testing