add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG #4179

rkpagadala · 2018-03-11T02:54:11Z

PROXY_TAG now refers to the docker image tag build from file pilot/docker/Dockerfile.proxy or pilot/docker/Dockerfile.proxy_debug
PROXY_REPO_SHA refers to the sha of istio/proxy, and is used to download the envoy binary used to build the proxy docker image referred above.
fixes #4157

codecov · 2018-03-11T03:06:30Z

Codecov Report

Merging #4179 into master will increase coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #4179    +/-   ##
=======================================
+ Coverage      73%     74%    +1%     
=======================================
  Files         313     313            
  Lines       28855   28320   -535     
=======================================
- Hits        20996   20731   -265     
+ Misses       6534    6330   -204     
+ Partials     1325    1259    -66

Impacted Files	Coverage Δ
mixer/adapter/servicecontrol/reportprocessor.go	`80% <0%> (-4%)`	⬇️
...olarwinds/internal/papertrail/papertrail_logger.go	`59% <0%> (-3%)`	⬇️
pilot/pkg/config/kube/crd/controller.go	`77% <0%> (-1%)`	⬇️
mixer/adapter/kubernetesenv/cache.go	`83% <0%> (-1%)`	⬇️
pilot/pkg/proxy/envoy/v2/mesh.go	`75% <0%> (ø)`	⬇️
mixer/adapter/list/list.go	`100% <0%> (ø)`	⬇️
mixer/adapter/list/ipList.go	`100% <0%> (ø)`	⬆️
mixer/cmd/mixc/cmd/report.go	`0% <0%> (ø)`	⬆️
pilot/pkg/model/gateway.go	`100% <0%> (ø)`	⬆️
mixer/adapter/memquota/dedup.go	`100% <0%> (ø)`	⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d70d1...c2e51a2. Read the comment docs.

rkpagadala · 2018-03-11T04:51:44Z

/test istio-pilot-e2e

rkpagadala · 2018-03-11T05:33:09Z

install/updateVersion.sh

@@ -50,17 +49,22 @@ EOF
  exit 2
 }

-source "$SRC_VERSION_FILE" || error_exit "Could not source versions"
+# set the default values


these values came from istio.VERSION, missing this caused the post-submit failures

ldemailly

try#2 ? it'll work this time :-) ?

ldemailly · 2018-03-11T05:47:57Z

/lgtm

istio-merge-robot · 2018-03-11T05:48:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

ldemailly · 2018-03-11T05:48:57Z

did you check the build that failed before will not this time, and matt's point about the release process?

istio-merge-robot · 2018-03-11T05:49:19Z

/test all [submit-queue is verifying that this PR is safe to merge]

ldemailly · 2018-03-11T05:50:03Z

that new error about

I0311 02:08:31.369]     pilot_test.go:89: configmaps "istio" not found
I0311 02:08:31.369] FAIL

is recent but unrelated - maybe because of #4024 - @andraxylia ?

istio-merge-robot · 2018-03-11T06:04:17Z

Automatic merge from submit-queue.

istio-testing · 2018-03-11T06:06:58Z

@rkpagadala: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/istio-pilot-e2e.sh	`c2e51a2`	link	`/test istio-pilot-e2e`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rkpagadala · 2018-03-11T07:02:44Z

@ldemailly the way I tested it is by making sure that the old files generated and the files after my change are identical. Missed eureka and consul fixes in #4181 for your consideration.

About Matt's point we don't need any changes in daily release for the release process. There are unrelated but needed changes that I asked Charles to make.

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: 2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (istio#1939) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (istio#4190) 36809d80a fuzz: coverage profile generation instructions. (istio#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075) 05c0d52d3 build: use clang-6.0. (istio#4168) 01f403ec4 thrift_proxy: introduce header transport (istio#4082) 564d256fb tcp: allow connection pool callers to store protocol state (istio#4131) 3e1d643b9 configs: match latest API changes (istio#4185) bc6a10c2f Fix wrong mock function name. (istio#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182) 3d1325e89 Converting envoy configs to V2 (istio#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157) 71152b710 ratelimit: Add ratelimit custom response headers (istio#4015) 306287418 ssl: make Ssl::Connection const everywhere (istio#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130) 8c189a552 Make over provisioning factor configurable (istio#4003) 6c08fb43c Making test less flaky (istio#4149) 592775b7b fuzz: bare bones HCM fuzzer. (istio#4118) For istio#7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (istio#1938) a32a587 Add a check cache test for string map sub keys (istio#1931) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (istio#4190) 36809d80a fuzz: coverage profile generation instructions. (istio#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075) 05c0d52d3 build: use clang-6.0. (istio#4168) 01f403ec4 thrift_proxy: introduce header transport (istio#4082) 564d256fb tcp: allow connection pool callers to store protocol state (istio#4131) 3e1d643b9 configs: match latest API changes (istio#4185) bc6a10c2f Fix wrong mock function name. (istio#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182) 3d1325e89 Converting envoy configs to V2 (istio#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157) 71152b710 ratelimit: Add ratelimit custom response headers (istio#4015) 306287418 ssl: make Ssl::Connection const everywhere (istio#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130) 8c189a552 Make over provisioning factor configurable (istio#4003) 6c08fb43c Making test less flaky (istio#4149) 592775b7b fuzz: bare bones HCM fuzzer. (istio#4118) For istio#7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

…). (#8161) This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: 2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (#1939) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (#4190) 36809d80a fuzz: coverage profile generation instructions. (#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (#4075) 05c0d52d3 build: use clang-6.0. (#4168) 01f403ec4 thrift_proxy: introduce header transport (#4082) 564d256fb tcp: allow connection pool callers to store protocol state (#4131) 3e1d643b9 configs: match latest API changes (#4185) bc6a10c2f Fix wrong mock function name. (#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182) 3d1325e89 Converting envoy configs to V2 (#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157) 71152b710 ratelimit: Add ratelimit custom response headers (#4015) 306287418 ssl: make Ssl::Connection const everywhere (#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (#4130) 8c189a552 Make over provisioning factor configurable (#4003) 6c08fb43c Making test less flaky (#4149) 592775b7b fuzz: bare bones HCM fuzzer. (#4118) For #7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

This is far from finished, but it reduces memory usage by ~10%. Pulling the following changes from github.com/istio/proxy: c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (#1938) a32a587 Add a check cache test for string map sub keys (#1931) Pulling the following changes from github.com/envoyproxy/envoy: c1cc68dda stats: refactoring MetricImpl without strings (#4190) 36809d80a fuzz: coverage profile generation instructions. (#4193) ba40cc933 upstream: rebuild cluster when health check config is changed (#4075) 05c0d52d3 build: use clang-6.0. (#4168) 01f403ec4 thrift_proxy: introduce header transport (#4082) 564d256fb tcp: allow connection pool callers to store protocol state (#4131) 3e1d643b9 configs: match latest API changes (#4185) bc6a10c2f Fix wrong mock function name. (#4187) e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182) 3d1325e89 Converting envoy configs to V2 (#2957) 8d0680feb Add timestamp to HealthCheckEvent definition (#4119) 497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173) 6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171) 132302caf fuzz: reduce log level when running under fuzz engine. (#4161) 7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155) 1b2219bd7 ci: remove deprecated bazel --batch option (#4166) 2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157) 71152b710 ratelimit: Add ratelimit custom response headers (#4015) 306287418 ssl: make Ssl::Connection const everywhere (#4179) 706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007) f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156) 27fb1d353 thrift_proxy: add service name matching to router implementation (#4130) 8c189a552 Make over provisioning factor configurable (#4003) 6c08fb43c Making test less flaky (#4149) 592775b7b fuzz: bare bones HCM fuzzer. (#4118) For #7912. Signed-off-by: Piotr Sikora <piotrsikora@google.com>

add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG

c2e51a2

rkpagadala requested review from a team March 11, 2018 02:54

googlebot added the cla: yes label Mar 11, 2018

rkpagadala requested review from ldemailly and mattdelco March 11, 2018 02:54

rkpagadala commented Mar 11, 2018

View reviewed changes

ldemailly approved these changes Mar 11, 2018

View reviewed changes

istio-testing assigned ldemailly Mar 11, 2018

istio-testing added the lgtm label Mar 11, 2018

istio-merge-robot added the approved label Mar 11, 2018

istio-merge-robot merged commit 3988402 into istio:master Mar 11, 2018

rkpagadala mentioned this pull request Mar 12, 2018

proxy_init uses proxy hub/tag, fix mixer health yaml generation #4193

Merged

This was referenced Aug 23, 2018

Update Proxy SHA to latest with MetricImpl optimizations. #8160

Merged

Update Proxy SHA to latest with MetricImpl optimizations (release-1.0). #8161

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG #4179

add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG #4179

Uh oh!

rkpagadala commented Mar 11, 2018

Uh oh!

codecov bot commented Mar 11, 2018 •

edited

Loading

Uh oh!

rkpagadala commented Mar 11, 2018

Uh oh!

rkpagadala Mar 11, 2018 •

edited

Loading

Uh oh!

ldemailly left a comment

Uh oh!

ldemailly commented Mar 11, 2018

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

ldemailly commented Mar 11, 2018

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

ldemailly commented Mar 11, 2018 •

edited

Loading

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

istio-testing commented Mar 11, 2018 •

edited

Loading

Uh oh!

rkpagadala commented Mar 11, 2018

Uh oh!

Uh oh!

add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG #4179

add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG #4179

Uh oh!

Conversation

rkpagadala commented Mar 11, 2018

Uh oh!

codecov bot commented Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rkpagadala commented Mar 11, 2018

Uh oh!

rkpagadala Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly left a comment

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Mar 11, 2018

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

ldemailly commented Mar 11, 2018

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

ldemailly commented Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

istio-merge-robot commented Mar 11, 2018

Uh oh!

istio-testing commented Mar 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rkpagadala commented Mar 11, 2018

Uh oh!

Uh oh!

codecov bot commented Mar 11, 2018 •

edited

Loading

rkpagadala Mar 11, 2018 •

edited

Loading

ldemailly commented Mar 11, 2018 •

edited

Loading

istio-testing commented Mar 11, 2018 •

edited

Loading