Skip to content

Revert "add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG" #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert "add PROXY_REPO_SHA removing overloaded meaning of PROXY_TAG" #4171

wants to merge 3 commits into from

Conversation

sebastienvas
Copy link
Contributor

Reverts #4158

@sebastienvas sebastienvas requested review from a team March 10, 2018 07:26
@ldemailly
Copy link
Member

why? what is broken/the problem?

@ldemailly
Copy link
Member

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@sebastienvas
Copy link
Contributor Author

I0310 07:22:52.161] error when retrieving current configuration of:
I0310 07:22:52.161] &{0xc420ad1200 0xc420221420 /home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml 0xc420f900f8 0xc420f900f8 false}
I0310 07:22:52.161] from server for: "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": resource name may not be empty
I0310 07:22:52.161] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-pilot-admin-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.161] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-sidecar-injector-admin-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.162] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-ca-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.162] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-ingress-admin-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.162] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-sidecar-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.162] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-mixer-admin-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.163] Error from server (Invalid): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "istio-mixer-validator-admin-role-binding-" is invalid: subjects[0].namespace: Required value
I0310 07:22:52.163] Error from server (NotFound): error when creating "/home/bootstrap/go/src/istio.io/istio/_artifacts/simple-auth-test-3c8cd21a6a0a4b08ab98/yaml/istio-one-namespace-auth.yaml": namespaces "simple-auth-test-

@sebastienvas
Copy link
Contributor Author

namespace is not set the generated yaml file

@istio-testing
Copy link
Collaborator

istio-testing commented Mar 10, 2018 •
edited
Loading

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh e59a509 link /test istio-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sebastienvas
Copy link
Contributor Author

/hold
I want to make sure this is the right PR

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Mar 10, 2018
@sebastienvas
Copy link
Contributor Author

/hold cancel

@istio-testing istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Mar 10, 2018
@rkpagadala
Copy link
Contributor

Thanks Seb. I merged the other pr from Mandar

@rkpagadala rkpagadala closed this Mar 10, 2018
@sebastienvas sebastienvas deleted the revert-4158-master branch March 10, 2018 20:46
PiotrSikora added a commit to PiotrSikora/istio that referenced this pull request Aug 23, 2018
@PiotrSikora
Update Proxy SHA to latest with MetricImpl optimizations (release-1.0).
8f2c833 
This is far from finished, but it reduces memory usage by ~10%.

Pulling the following changes from github.com/istio/proxy:

2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (istio#1939)

Pulling the following changes from github.com/envoyproxy/envoy:

c1cc68dda stats: refactoring MetricImpl without strings (istio#4190)
36809d80a fuzz: coverage profile generation instructions. (istio#4193)
ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075)
05c0d52d3 build: use clang-6.0. (istio#4168)
01f403ec4 thrift_proxy: introduce header transport (istio#4082)
564d256fb tcp: allow connection pool callers to store protocol state (istio#4131)
3e1d643b9 configs: match latest API changes (istio#4185)
bc6a10c2f Fix wrong mock function name. (istio#4187)
e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182)
3d1325e89 Converting envoy configs to V2 (istio#2957)
8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119)
497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173)
6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171)
132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161)
7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155)
1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166)
2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157)
71152b710 ratelimit: Add ratelimit custom response headers (istio#4015)
306287418 ssl: make Ssl::Connection const everywhere (istio#4179)
706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007)
f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156)
27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130)
8c189a552 Make over provisioning factor configurable (istio#4003)
6c08fb43c Making test less flaky (istio#4149)
592775b7b fuzz: bare bones HCM fuzzer. (istio#4118)

For istio#7912.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit to PiotrSikora/istio that referenced this pull request Aug 23, 2018
@PiotrSikora
Update Proxy SHA to latest with MetricImpl optimizations.
8ed2ed5 
This is far from finished, but it reduces memory usage by ~10%.

Pulling the following changes from github.com/istio/proxy:

c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (istio#1938)
a32a587 Add a check cache test for string map sub keys (istio#1931)

Pulling the following changes from github.com/envoyproxy/envoy:

c1cc68dda stats: refactoring MetricImpl without strings (istio#4190)
36809d80a fuzz: coverage profile generation instructions. (istio#4193)
ba40cc933 upstream: rebuild cluster when health check config is changed (istio#4075)
05c0d52d3 build: use clang-6.0. (istio#4168)
01f403ec4 thrift_proxy: introduce header transport (istio#4082)
564d256fb tcp: allow connection pool callers to store protocol state (istio#4131)
3e1d643b9 configs: match latest API changes (istio#4185)
bc6a10c2f Fix wrong mock function name. (istio#4187)
e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (istio#4182)
3d1325e89 Converting envoy configs to V2 (istio#2957)
8d0680feb Add timestamp to HealthCheckEvent definition (istio#4119)
497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (istio#4173)
6d6fafdb3 config: strengthen validation for gRPC config sources. (istio#4171)
132302caf fuzz: reduce log level when running under fuzz engine. (istio#4161)
7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (istio#4155)
1b2219bd7 ci: remove deprecated bazel --batch option (istio#4166)
2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (istio#4157)
71152b710 ratelimit: Add ratelimit custom response headers (istio#4015)
306287418 ssl: make Ssl::Connection const everywhere (istio#4179)
706e26238 Handle validation of non expiring tokens in jwt_authn filter (istio#4007)
f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (istio#4156)
27fb1d353 thrift_proxy: add service name matching to router implementation (istio#4130)
8c189a552 Make over provisioning factor configurable (istio#4003)
6c08fb43c Making test less flaky (istio#4149)
592775b7b fuzz: bare bones HCM fuzzer. (istio#4118)

For istio#7912.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This was referenced Aug 23, 2018
Merged
Merged
rshriram pushed a commit that referenced this pull request Aug 23, 2018
@PiotrSikora @rshriram
Update Proxy SHA to latest with MetricImpl optimizations (release-1.0…
459bb34 
…). (#8161)

This is far from finished, but it reduces memory usage by ~10%.

Pulling the following changes from github.com/istio/proxy:

2656f34 Update Envoy SHA to latest with MetricImpl optimizations (release-1.0). (#1939)

Pulling the following changes from github.com/envoyproxy/envoy:

c1cc68dda stats: refactoring MetricImpl without strings (#4190)
36809d80a fuzz: coverage profile generation instructions. (#4193)
ba40cc933 upstream: rebuild cluster when health check config is changed (#4075)
05c0d52d3 build: use clang-6.0. (#4168)
01f403ec4 thrift_proxy: introduce header transport (#4082)
564d256fb tcp: allow connection pool callers to store protocol state (#4131)
3e1d643b9 configs: match latest API changes (#4185)
bc6a10c2f Fix wrong mock function name. (#4187)
e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182)
3d1325e89 Converting envoy configs to V2 (#2957)
8d0680feb Add timestamp to HealthCheckEvent definition (#4119)
497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173)
6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171)
132302caf fuzz: reduce log level when running under fuzz engine. (#4161)
7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155)
1b2219bd7 ci: remove deprecated bazel --batch option (#4166)
2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157)
71152b710 ratelimit: Add ratelimit custom response headers (#4015)
306287418 ssl: make Ssl::Connection const everywhere (#4179)
706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007)
f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156)
27fb1d353 thrift_proxy: add service name matching to router implementation (#4130)
8c189a552 Make over provisioning factor configurable (#4003)
6c08fb43c Making test less flaky (#4149)
592775b7b fuzz: bare bones HCM fuzzer. (#4118)

For #7912.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
istio-testing pushed a commit that referenced this pull request Aug 24, 2018
@PiotrSikora @istio-testing
Update Proxy SHA to latest with MetricImpl optimizations. (#8160)
1ad52e3 
This is far from finished, but it reduces memory usage by ~10%.

Pulling the following changes from github.com/istio/proxy:

c9d2230 Update Envoy SHA to latest with MetricImpl optimizations. (#1938)
a32a587 Add a check cache test for string map sub keys (#1931)

Pulling the following changes from github.com/envoyproxy/envoy:

c1cc68dda stats: refactoring MetricImpl without strings (#4190)
36809d80a fuzz: coverage profile generation instructions. (#4193)
ba40cc933 upstream: rebuild cluster when health check config is changed (#4075)
05c0d52d3 build: use clang-6.0. (#4168)
01f403ec4 thrift_proxy: introduce header transport (#4082)
564d256fb tcp: allow connection pool callers to store protocol state (#4131)
3e1d643b9 configs: match latest API changes (#4185)
bc6a10c2f Fix wrong mock function name. (#4187)
e994c1c0b Bump yaml-cpp so it builds with Visual Studio 15.8 (#4182)
3d1325e89 Converting envoy configs to V2 (#2957)
8d0680feb Add timestamp to HealthCheckEvent definition (#4119)
497efb95b server: handle non-EnvoyExceptions safely if thrown in constructor. (#4173)
6d6fafdb3 config: strengthen validation for gRPC config sources. (#4171)
132302caf fuzz: reduce log level when running under fuzz engine. (#4161)
7c04ac255 test: fix V6EmptyOptions in coverage with IPv6 enable (#4155)
1b2219bd7 ci: remove deprecated bazel --batch option (#4166)
2db6a4ce1 ci: update clang to version 6.0 in the Ubuntu build image. (#4157)
71152b710 ratelimit: Add ratelimit custom response headers (#4015)
306287418 ssl: make Ssl::Connection const everywhere (#4179)
706e26238 Handle validation of non expiring tokens in jwt_authn filter (#4007)
f06e9588a fuzz: tag trivial fuzzers with no_fuzz. (#4156)
27fb1d353 thrift_proxy: add service name matching to router implementation (#4130)
8c189a552 Make over provisioning factor configurable (#4003)
6c08fb43c Making test less flaky (#4149)
592775b7b fuzz: bare bones HCM fuzzer. (#4118)

For #7912.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ldemailly ldemailly

@rkpagadala rkpagadala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastienvas @ldemailly @istio-merge-robot @istio-testing @rkpagadala @googlebot