ambient: support telemetry tracing on waypoint #41656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
reviewed
Oct 27, 2022
There was a problem hiding this comment.
Are we sure we need tracing for this? Its like adding tracing for TCP connections essentially... but not really since they are multiplexed.
Won't we just have a few really long spans, which aren't correlated with any inner-requests? I am not sure what value they add
21f0d44 to
e9e8203
Compare
|
/retest-required |
|
/retest |
|
/test integ-ambient |
5b55c19 to
c8c4df8
Compare
c8c4df8 to
055f414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR: