Skip to content

Try asan #41470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Try asan #41470

wants to merge 4 commits into from

Conversation

kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Oct 17, 2022 •
edited
Loading

Main issues:

  1. libc++ is dynamically linked on Asan build
  2. Timeouts are too aggressive, Asan can be 10x slower.

@kyessenov kyessenov requested review from a team as code owners October 17, 2022 20:43
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2022
@kyessenov
Copy link
Contributor Author

The problem is that the Dockerfile is parsed manually and "RUN" is somehow decided to be ignored without errors.
@howardjohn how do I use regular docker for a test run instead of the hand-written one?

@kyessenov
Copy link
Contributor Author

/retest

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 17, 2022
@kyessenov
Copy link
Contributor Author

Oink

@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Nov 17, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Dec 18, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jan 2, 2023
@kyessenov kyessenov reopened this Jan 3, 2023
@kyessenov kyessenov added lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed and removed lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. labels Jan 3, 2023
@kyessenov kyessenov requested a review from a team January 19, 2023 20:26
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2023
@kyessenov kyessenov added the release-notes-none Indicates a PR that does not require release notes. label Jan 19, 2023
@kyessenov
Copy link
Contributor Author

/retest

@kyessenov kyessenov mentioned this pull request Jan 20, 2023
Merged
@kyessenov
install libc++
94b4438 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2023
@kyessenov
bump memory
3b3265b 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov requested a review from a team as a code owner January 20, 2023 23:28
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2023
@kyessenov
Copy link
Contributor Author

/retest

6 similar comments
@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

@kyessenov
Copy link
Contributor Author

/retest

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 24, 2023
@kyessenov
fix
815deca 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
kick it
17949b1 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 28, 2023
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 6, 2023
@istio-testing
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Collaborator

@kyessenov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio 17949b1 link true /test lint
unit-tests-arm64_istio 17949b1 link true /test unit-tests-arm64
unit-tests_istio 17949b1 link true /test unit-tests
integ-telemetry-istiodremote_istio 17949b1 link true /test integ-telemetry-istiodremote
integ-telemetry_istio 17949b1 link true /test integ-telemetry
integ-ipv6_istio 17949b1 link true /test integ-ipv6
integ-ds_istio 17949b1 link true /test integ-ds
integ-distroless_istio 17949b1 link true /test integ-distroless
integ-telemetry-mc_istio 17949b1 link true /test integ-telemetry-mc
integ-security-istiodremote_istio 17949b1 link true /test integ-security-istiodremote
integ-cni_istio 17949b1 link true /test integ-cni
integ-security_istio 17949b1 link true /test integ-security
integ-pilot-multicluster_istio 17949b1 link true /test integ-pilot-multicluster
bookinfo-build_istio 17949b1 link true /test bookinfo-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov kyessenov mentioned this pull request May 10, 2023
Closed
6 tasks
@howardjohn howardjohn removed the lifecycle/staleproof Indicates a PR or issue has been deemed to be immune from becoming stale and/or automatically closed label Jun 13, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-01-30. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyessenov @istio-testing @istio-policy-bot @howardjohn