Skip to content

[release-1.14] manual cherry pick 39729 #40189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 1, 2022
Merged

[release-1.14] manual cherry pick 39729 #40189

merged 5 commits into from
Aug 1, 2022

Conversation

hanxiaop
Copy link
Member

@hanxiaop hanxiaop commented Jul 31, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:
#39841 failed. Manual cherry-pick and fix ut.

@GregHanson PTAl. #39841 This one failed because I didn't cherry-pick #37581, and I used v1beta1 in the test. Just revised the ut to v1alpha3.

@hanxiaop hanxiaop requested a review from a team July 31, 2022 12:06
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 31, 2022
@hanxiaop hanxiaop mentioned this pull request Jul 31, 2022
Closed
@istio-testing istio-testing merged commit b560227 into istio:release-1.14 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@GregHanson GregHanson GregHanson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanxiaop @GregHanson @istio-testing