Skip to content

remove comments #40990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2022
Merged

remove comments #40990

merged 2 commits into from
Sep 14, 2022

Conversation

yingzhuivy
Copy link
Member

@yingzhuivy yingzhuivy commented Sep 14, 2022 •
edited
Loading

Please provide a description of this PR:

followup #40966 (comment)

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@yingzhuivy yingzhuivy requested a review from a team as a code owner September 14, 2022 17:57
@istio-policy-bot istio-policy-bot added the release-notes-none Indicates a PR that does not require release notes. label Sep 14, 2022
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2022
@yingzhuivy yingzhuivy mentioned this pull request Sep 14, 2022
Merged
@yingzhuivy
Copy link
Member Author

lint still fails if remove the nolint so i just updated the comments to be more accurate

@istio-testing istio-testing merged commit 8af3aff into istio:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yingzhuivy @howardjohn @istio-testing @istio-policy-bot