Adding min istio version for new features to avoid running on older revisions #40892
Conversation
…evisions
We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :-
a. gRPC fault
injection(istio#39295)
b. Ignore port number in domain
matching(istio#40475)
c. Tunneling outbound traffic :- new tunnel field got
introduced(istio#37968)
d. Fix consistent hash based on source IP for TCP
proxy(istio#38438)
e. Traffic policy load balancer API
changes(istio#39742)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @hemendrateli. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Not sure i understand why you are testing older istio version with test cases in master |
|
/cc @stewartbutler |
|
@hzxuzhonghu This is to test migration use case where multiple versions are installed and workloads communicate across revisions. |
|
/ok-to-test |
| @@ -147,6 +151,7 @@ func TestReachability(t *testing.T) { | |||
| expectCrossCluster: notFromNaked, | |||
| expectCrossNetwork: notNaked, | |||
| expectSuccess: notToNaked, | |||
| minIstioVersion: "1.15.0", | |||
There was a problem hiding this comment.
does that mean it won't work for versions lesser than 1.15 ?
There was a problem hiding this comment.
- If we try to test this master branch reachability tests against versions lesser than 1.15 then it won't work (so we are trying to skip) because of new API changes done(PR#39742) which are not there in version 1.13.
- 1.13 branch already has its reachability tests which will work on 1.13 version.
|
/retest |
|
/cherrypick release-1.15 |
|
@stewartbutler: new pull request created: #40957 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please provide a description of this PR:
We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :-
a. gRPC fault
injection(#39295)
b. Ignore port number in domain
matching(#40475)
c. Tunneling outbound traffic :- new tunnel field got
introduced(#37968)
d. Fix consistent hash based on source IP for TCP
proxy(#38438)
e. Traffic policy load balancer API
changes(#39742)
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.