Skip to content

Wait until TCP proxy port is working before sending data to that port. #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2018
Merged

Wait until TCP proxy port is working before sending data to that port. #4073

merged 1 commit into from
Mar 8, 2018

Conversation

JimmyCYJ
Copy link
Member

@JimmyCYJ JimmyCYJ commented Mar 8, 2018 •
edited
Loading

Fix flaky test #3946

@JimmyCYJ JimmyCYJ requested a review from a team March 8, 2018 02:16
@JimmyCYJ JimmyCYJ requested a review from qiwzhang March 8, 2018 02:16
@codecov
Copy link

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #4073 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4073    +/-   ##
=======================================
+ Coverage      75%     75%    +1%     
=======================================
  Files         305     305            
  Lines       28014   27566   -448     
=======================================
- Hits        20786   20563   -223     
+ Misses       5874    5712   -162     
+ Partials     1354    1291    -63
Impacted Files Coverage Δ
security/pkg/pki/util/generate_cert.go 61% <0%> (-22%) ⬇️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
security/cmd/flexvolume/driver/driver.go 45% <0%> (ø) ⬆️
mixer/adapter/memquota/dedup.go 100% <0%> (ø) ⬆️
mixer/template/sample/template.gen.go 55% <0%> (+1%) ⬆️
pilot/pkg/proxy/envoy/v2/mesh.go 76% <0%> (+1%) ⬆️
mixer/adapter/stdio/zap.go 99% <0%> (+2%) ⬆️
mixer/adapter/denier/denier.go 95% <0%> (+3%) ⬆️
mixer/adapter/servicecontrol/testhelper.go 74% <0%> (+3%) ⬆️
mixer/adapter/circonus/circonus.go 73% <0%> (+6%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf132d2...7b63c39. Read the comment docs.

douglas-reid
douglas-reid approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit b0354c8 into istio:master Mar 8, 2018
@istio-testing
Copy link
Collaborator

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests.sh 7b63c39 link /test e2e-simple
prow/e2e-bookInfoTests.sh 7b63c39 link /test e2e-bookInfo
prow/istio-pilot-e2e.sh 7b63c39 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ JimmyCYJ deleted the debug-tcp_filter_periodical_report branch March 8, 2018 17:48
@qiwzhang qiwzhang mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiwzhang qiwzhang Awaiting requested review from qiwzhang

1 more reviewer

@douglas-reid douglas-reid douglas-reid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@douglas-reid douglas-reid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JimmyCYJ @istio-merge-robot @istio-testing @douglas-reid @googlebot