Compare handlers names, instead of the interfaces during routing build. #4069
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4069 +/- ##
=======================================
+ Coverage 75% 75% +1%
=======================================
Files 305 305
Lines 28014 27746 -268
=======================================
- Hits 20786 20619 -167
+ Misses 5874 5785 -89
+ Partials 1354 1342 -12
Continue to review full report at Codecov.
|
…oute build.
+ Comparing the interfaces are problematic, as it causes panics when
the underlying type is a struct{}, instead of &struct{}. Most adapters
are pointers, so this doesn't seem to come up under normal conditions, it
came up only during end-to-end testing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@ozevren: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Comparing the interfaces are problematic, as it causes panics when the underlying type is a struct{} (and has non-comparable members). instead of &struct{}.