Skip to content

Conversation

mandarjog
Copy link
Contributor

Use REST_LEGACY for SDS until grpc is fixed.

@mandarjog mandarjog requested a review from a team March 8, 2018 01:02
@ldemailly
Copy link
Member

/lgtm

@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldemailly

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@ldemailly ldemailly merged commit dff8fcb into istio:master Mar 8, 2018
@ldemailly
Copy link
Member

sorry I messed up and this had to be redone - my bad

@istio-testing
Copy link
Collaborator

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests.sh 2ade7e4 link /test e2e-simple
prow/e2e-bookInfoTests.sh 2ade7e4 link /test e2e-bookInfo
prow/istio-pilot-e2e.sh 2ade7e4 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants