`istioctl x proxy-status` via istio agents. #40623

ingwonsong · 2022-08-24T03:53:25Z

This PR proposes an experimental option --xds-via-agents only for istioctl x proxy-status command, which sends a query for istioctl x proxy-status via istio agents, instead of direct query to istiod.

istioctl x proxy-status try to find all the istiod instances by searching pods in istio-system namespace.
But, if we use the external istiods, this way may not work.

For example, istiod can be deployed in the other cluster or out of K8S. Moreover, in front of the istiod instances, some sort of load balancer can be set to distribute the connections to multiple istiods. This kind of configuration may happen when the customer want to isolate their control plane from the workloads, or when they are using some managed control plane.

In such case, istioctl x proxy-status cannot enumerate and access to each istiod instance directly. So, this PR proposes to access istiod via "istio agent".

Please note that, by #40566, we can make a query to istiod via istio agents efficiently.

istioctl/pkg/multixds/gather.go

istioctl/cmd/proxystatus.go

pkg/kube/client.go

zirain

lgtm

pkg/kube/client.go

istioctl/pkg/multixds/gather.go

ingwonsong · 2022-08-27T08:01:25Z

@therealmitchconnors Wam reminder

ingwonsong · 2022-08-30T23:53:40Z

To wait for #40721, I set this to do-not-merge.

ingwonsong · 2022-09-01T21:24:43Z

As #40721 supports the 15004 port as well, don't need to wait for the PR.

istioctl/pkg/multixds/gather.go

Co-authored-by: John Howard <howardjohn@google.com>

… pods

ingwonsong · 2022-09-17T00:48:23Z

/retest

* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com>

ingwonsong · 2022-09-18T15:15:14Z

/cherrypick release-1.15

istio-testing · 2022-09-18T15:15:53Z

@ingwonsong: #40623 failed to apply on top of branch "release-1.15":

Applying: `istioctl ps` via istio agents.
Applying: Fix lint errors
Applying: Fix lint errors
Applying: Use k8s client_go instead of RESTClient
Applying: Update pkg/kube/client.go
Applying: Use constant for "status.phase=Running"
Applying: Use the revision in the annotation instead of labels for the injected pods
Applying: Add xds-via-agents-limit flag
Applying: Reflect the comments and refactoring
Using index info to reconstruct a base tree...
M	istioctl/cmd/internal-debug.go
M	istioctl/cmd/proxystatus.go
M	istioctl/pkg/multixds/gather.go
Falling back to patching base and 3-way merge...
Auto-merging istioctl/pkg/multixds/gather.go
CONFLICT (content): Merge conflict in istioctl/pkg/multixds/gather.go
Auto-merging istioctl/cmd/proxystatus.go
Auto-merging istioctl/cmd/internal-debug.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0009 Reflect the comments and refactoring
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing · 2022-09-18T15:15:55Z

@ingwonsong: new issue created for failed cherrypick: #41040

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: John Howard <howardjohn@google.com>

* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com>

* Send only the Cluster ID (#40477) * Add Tap gRPC handler to Istio Agent. (#40566) * Add Tap GRPC handler to Istio Agent. * Fix lint errors * Add the integration test * `istioctl x proxy-status` via istio agents. (#40623) * `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com> Co-authored-by: John Howard <howardjohn@google.com>

* `istioctl ps` via istio agents. * Fix lint errors * Fix lint errors * Use k8s client_go instead of RESTClient * Update pkg/kube/client.go Co-authored-by: John Howard <howardjohn@google.com> * Use constant for "status.phase=Running" * Use the revision in the annotation instead of labels for the injected pods * Add xds-via-agents-limit flag * Reflect the comments and refactoring Co-authored-by: John Howard <howardjohn@google.com>

ingwonsong requested review from a team as code owners August 24, 2022 03:53

istio-policy-bot added the area/user experience label Aug 24, 2022

istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2022

ingwonsong added the release-notes-none Indicates a PR that does not require release notes. label Aug 24, 2022

zirain reviewed Aug 24, 2022

View reviewed changes

istioctl/pkg/multixds/gather.go Outdated Show resolved Hide resolved

zirain reviewed Aug 24, 2022

View reviewed changes

istioctl/cmd/proxystatus.go Outdated Show resolved Hide resolved

ingwonsong force-pushed the istio-ps-via-agent branch from 2c7af56 to 3e1aa6f Compare August 24, 2022 04:18

ingwonsong requested a review from zirain August 24, 2022 04:29

ingwonsong force-pushed the istio-ps-via-agent branch from 3e1aa6f to c36f181 Compare August 24, 2022 04:36

hzxuzhonghu reviewed Aug 24, 2022

View reviewed changes

pkg/kube/client.go Outdated Show resolved Hide resolved

ingwonsong requested a review from hzxuzhonghu August 24, 2022 12:35

howardjohn reviewed Aug 24, 2022

View reviewed changes

pkg/kube/client.go Outdated Show resolved Hide resolved

zirain approved these changes Aug 25, 2022

View reviewed changes

ingwonsong force-pushed the istio-ps-via-agent branch from 0290557 to 751224d Compare August 25, 2022 16:26

ingwonsong requested a review from therealmitchconnors August 25, 2022 21:43

hzxuzhonghu reviewed Aug 26, 2022

View reviewed changes

pkg/kube/client.go Outdated Show resolved Hide resolved

pkg/kube/client.go Outdated Show resolved Hide resolved

istioctl/pkg/multixds/gather.go Outdated Show resolved Hide resolved

ingwonsong force-pushed the istio-ps-via-agent branch from eecfec6 to 7d21e6f Compare August 26, 2022 17:25

ingwonsong requested a review from howardjohn August 26, 2022 17:59

hzxuzhonghu approved these changes Aug 27, 2022

View reviewed changes

ingwonsong force-pushed the istio-ps-via-agent branch from 7d21e6f to e2a7cad Compare August 30, 2022 03:54

ingwonsong added the do-not-merge Block automatic merging of a PR. label Aug 30, 2022

ingwonsong added area/user experience and removed do-not-merge Block automatic merging of a PR. area/user experience labels Sep 1, 2022

ingwonsong force-pushed the istio-ps-via-agent branch from e2a7cad to 0fa5de9 Compare September 7, 2022 20:55

therealmitchconnors reviewed Sep 14, 2022

View reviewed changes

istioctl/pkg/multixds/gather.go Show resolved Hide resolved

ingwonsong and others added 9 commits September 16, 2022 21:48

istioctl ps via istio agents.

6d940a6

Fix lint errors

ddd503d

Fix lint errors

4bd5c96

Use k8s client_go instead of RESTClient

21b9b7e

Update pkg/kube/client.go

2515409

Co-authored-by: John Howard <howardjohn@google.com>

Use constant for "status.phase=Running"

f5436f1

Use the revision in the annotation instead of labels for the injected…

f637787

… pods

Add xds-via-agents-limit flag

0c05bff

Reflect the comments and refactoring

ff19141

ingwonsong force-pushed the istio-ps-via-agent branch from 6901a76 to ff19141 Compare September 16, 2022 21:49

therealmitchconnors approved these changes Sep 17, 2022

View reviewed changes

istio-testing merged commit d86fa8b into istio:master Sep 17, 2022

This was referenced Sep 17, 2022

[release-1.15] istioctl x proxy-status via istio agents. (#40623) #41034

Closed

[release-1.15] istioctl x proxy-status via istio agents. (#40623) #41035

Closed

ingwonsong deleted the istio-ps-via-agent branch September 17, 2022 22:29

istio-testing mentioned this pull request Sep 18, 2022

[release-1.15] istioctl x proxy-status via istio agents. #41040

Closed

ingwonsong mentioned this pull request Sep 19, 2022

[release-1.14] cherrypick for "istioctl x ps --xds-via-agents" #41056

Merged

ingwonsong mentioned this pull request Oct 25, 2022

[release-1.13] cherrypick for "istioctl x ps --xds-via-agents" #41634

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

`istioctl x proxy-status` via istio agents. #40623

`istioctl x proxy-status` via istio agents. #40623

Uh oh!

ingwonsong commented Aug 24, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zirain left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ingwonsong commented Aug 27, 2022

Uh oh!

ingwonsong commented Aug 30, 2022

Uh oh!

ingwonsong commented Sep 1, 2022

Uh oh!

Uh oh!

ingwonsong commented Sep 17, 2022

Uh oh!

ingwonsong commented Sep 18, 2022

Uh oh!

istio-testing commented Sep 18, 2022

Uh oh!

istio-testing commented Sep 18, 2022

Uh oh!

Uh oh!

istioctl x proxy-status via istio agents. #40623

istioctl x proxy-status via istio agents. #40623

Uh oh!

Conversation

ingwonsong commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zirain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ingwonsong commented Aug 27, 2022

Uh oh!

ingwonsong commented Aug 30, 2022

Uh oh!

ingwonsong commented Sep 1, 2022

Uh oh!

Uh oh!

ingwonsong commented Sep 17, 2022

Uh oh!

ingwonsong commented Sep 18, 2022

Uh oh!

istio-testing commented Sep 18, 2022

Uh oh!

istio-testing commented Sep 18, 2022

Uh oh!

Uh oh!

`istioctl x proxy-status` via istio agents. #40623

`istioctl x proxy-status` via istio agents. #40623

ingwonsong commented Aug 24, 2022 •

edited

Loading