Skip to content

Cherry pick disable fsgroup injection by default #40559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kfaseela
Copy link
Member

This is a manual cherry-pick of 3 PRs from master. If cherry-picked separately, they had regression issues on older K8s versions, and hence doing the manual cherry-pick combining all the fixes, to avoid confusions on release-1.15

#40531
#40549
#40551

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

…stio#40531)

Signed-off-by: Faseela K <faseela.k@est.tech>

Signed-off-by: Faseela K <faseela.k@est.tech>
…o#40549)

The previous logic was available only for IstioOperator,
hence helm based integration tests on k8s 1.16 were failing.

Signed-off-by: Faseela K <faseela.k@est.tech>

Signed-off-by: Faseela K <faseela.k@est.tech>
Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela requested a review from a team August 19, 2022 06:45
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2022
@kfaseela
Copy link
Member Author

@ericvn @howardjohn I have manually cherry-picked combining all 3 PRs from master, as master post-submit tests are passing now.

@kfaseela kfaseela added the release-notes-none Indicates a PR that does not require release notes. label Aug 19, 2022
@kfaseela
Copy link
Member Author

/test release-notes

@ericvn
Copy link
Contributor

ericvn commented Aug 19, 2022

Thanks @kfaseela

@istio-testing istio-testing merged commit 116a6b7 into istio:release-1.15 Aug 19, 2022
@kfaseela kfaseela deleted the cherry-pick-disable-fsgroup-injection-by-default branch March 14, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants