Skip to content

Add automatic setting logic for ENABLE_LEGACY_FSGROUP_INJECTION #40549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add automatic setting logic for ENABLE_LEGACY_FSGROUP_INJECTION #40549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions manifests/charts/istio-control/istio-discovery/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ spec:
value: "{{ $val }}"
{{- end }}
{{- end }}
{{- if semverCompare "<1.19" .Capabilities.KubeVersion.GitVersion }}
- name: ENABLE_LEGACY_FSGROUP_INJECTION
Copy link
Contributor

@AndreaM12345 AndreaM12345 Aug 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does a check for JWT Policy values need to be added too? in the case of JWT_POLICY is "first-party-jwt" then ENABLE_LEGACY_FSGROUP_INJECTION needs to be false regardless of the kube version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to be false -- it just can be. IMO its not needed; this is strictly an improvement for Helm. While we could add the jwt check in helm as well, the jwt change is from Kubernetes 1.12 which is ~forever ago, so I am not sure its worth the effort

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thanks for the clarification

value: "true"
{{- end }}
{{- if .Values.pilot.traceSampling }}
- name: PILOT_TRACE_SAMPLING
value: "{{ .Values.pilot.traceSampling }}"
Expand Down