Skip to content

Add more test for driver.go #4054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 8, 2018
Merged

Add more test for driver.go #4054

merged 6 commits into from
Mar 8, 2018

Conversation

wattli
Copy link
Contributor

@wattli wattli commented Mar 7, 2018

No description provided.

@wattli wattli requested review from myidpt and a team March 7, 2018 22:48
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: lei-tang

Assign the PR to them by writing /assign @lei-tang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 8, 2018 •
edited
Loading

Codecov Report

Merging #4054 into master will increase coverage by 1%.
The diff coverage is 67%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #4054    +/-   ##
=======================================
+ Coverage      75%     76%    +1%     
=======================================
  Files         305     304     -1     
  Lines       27368   27231   -137     
=======================================
+ Hits        20390   20512   +122     
+ Misses       5686    5438   -248     
+ Partials     1292    1281    -11
Impacted Files Coverage Δ
security/cmd/flexvolume/driver/driver.go 45% <67%> (ø) ⬆️
mixer/adapter/kubernetesenv/cache.go 70% <0%> (-16%) ⬇️
mixer/adapter/rbac/controller.go 39% <0%> (-15%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-8%) ⬇️
mixer/adapter/servicecontrol/distValueBuilder.go 91% <0%> (ø) ⬇️
mixer/adapter/rbac/rbac.go 11% <0%> (ø) ⬇️
pilot/pkg/model/validation.go 89% <0%> (ø) ⬇️
mixer/adapter/dogstatsd/dogstatsd.go 100% <0%> (ø) ⬆️
mixer/adapter/memquota/rollingWindow.go 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c01a3f...f311d38. Read the comment docs.

@wattli wattli merged commit 203755c into istio:master Mar 8, 2018
@wattli wattli deleted the test2 branch March 8, 2018 01:17
@istio-testing
Copy link
Collaborator

@wattli: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh f311d38 link /test istio-unit-tests
prow/e2e-simpleTests.sh f311d38 link /test e2e-simple
prow/e2e-bookInfoTests.sh f311d38 link /test e2e-bookInfo
prow/istio-pilot-e2e.sh f311d38 link /test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@myidpt myidpt myidpt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wattli @istio-merge-robot @istio-testing @myidpt @googlebot @sakshigoel12