Skip to content

Cherrypick 40265 #40520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Conversation

GregHanson
Copy link
Member

@GregHanson GregHanson commented Aug 17, 2022

Please provide a description of this PR:

Manual cherry-pick of #40265 and dependent PR's #39313 and #38771

vince-0202 and others added 3 commits August 17, 2022 16:33
* Uniform pilot-agent and pilot-discover 's code style

* format
… stats metrics scraping (istio#39313)

* fixed issues for IPv4 and IPv6 compat for prometheus and applications stats scraping

* Fixed issues for IPv4 and IPv6 compat for application prober checking

* remove wrapIPv6 because it has been handled by other places

* revert other files but new change in pilot/cmd/pilot-agent/app/cmd.go

* fix the status server bugs when starting it

* add sts server to let InstanceIP decide the localhost

* s.appProbersDestination has already been wraped by wrapIPv6, unnecessary to use net.JoinHostPort
* fix issue#40245 for Sidecar in ipv6 defaultEndpoint format

* fix the lll go lint

* add unit test for sidecar's defaultEndpoint

* completed this fixing according to comments

* change code based on comments

* add comments in code for re-trigger the C

* check the IPv6 address by Net.IP to16

* check the IPv6 address by Net.IP to16
@GregHanson GregHanson requested a review from a team August 17, 2022 16:39
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 17, 2022
@GregHanson
Copy link
Member Author

resolves #40464

@GregHanson GregHanson added the release-notes-none Indicates a PR that does not require release notes. label Aug 17, 2022
@GregHanson
Copy link
Member Author

/test release-notes

@istio-testing istio-testing merged commit 24e569f into istio:release-1.14 Aug 17, 2022
@GregHanson GregHanson deleted the cherrypick-40265 branch August 17, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants