Skip to content

Respect ALPN negotiation in agent probe #40513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

Respect ALPN negotiation in agent probe #40513

merged 1 commit into from
Aug 17, 2022

Conversation

GregHanson
Copy link
Member

@GregHanson GregHanson commented Aug 17, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

manual cherry-pick of PR #40307

@howardjohn @GregHanson
Respect ALPN negotiation in agent prober (istio#40307)
9d151a8 
* Respect ALPN negotiation in agent prober

Fixes istio#40173

This aligns with kubelet probe, to support http2 for `HTTPS` probes.

Note: the request from kubelet->agent will always be HTTP/1.1 still,
just the upstream is changed.

* lint
@GregHanson GregHanson requested a review from a team August 17, 2022 13:10
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 17, 2022
@istio-testing istio-testing merged commit c7006e6 into istio:release-1.14 Aug 17, 2022
@GregHanson GregHanson deleted the cherrypick-40307 branch August 17, 2022 18:20
@GregHanson GregHanson mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lei-tang lei-tang lei-tang approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GregHanson @lei-tang @istio-testing @howardjohn