Support gRPC fault injection (allow specifying gRPC error codes for fault injection) #39295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: su225 <suchithjn22@gmail.com>
Signed-off-by: su225 <suchithjn22@gmail.com>
Signed-off-by: su225 <suchithjn22@gmail.com>
Signed-off-by: su225 <suchithjn22@gmail.com>
Signed-off-by: su225 <suchithjn22@gmail.com>
howardjohn
reviewed
Jun 6, 2022
| @@ -657,6 +658,36 @@ spec: | |||
| workloadAgnostic: true, | |||
| }) | |||
|
|
|||
| t.RunTraffic(TrafficTestCase{ | |||
| name: "fault abort gRPC", | |||
There was a problem hiding this comment.
we should try setting sourcematchers and targetMatchers to match.NotNaked, match.NotHeadless.
Currently we have proxyless grpc opted out; this seems like a REALLY useful feature for proxyless grpc.
I don't know if itworks though, so not certain that will pass
There was a problem hiding this comment.
Did it.
sourceMatchers: []match.Matcher{match.NotNaked, match.NotHeadless},
targetMatchers: []match.Matcher{match.NotNaked, match.NotHeadless},And it is 🟢
Let's enable it?
hemendrateli
added a commit
to hemendrateli/istio
that referenced
this pull request
Sep 9, 2022
…evisions
We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :-
a. gRPC fault
injection(istio#39295)
b. Ignore port number in domain
matching(istio#40475)
c. Tunneling outbound traffic :- new tunnel field got
introduced(istio#37968)
d. Fix consistent hash based on source IP for TCP
proxy(istio#38438)
e. Traffic policy load balancer API
changes(istio#39742)
10 tasks
istio-testing
pushed a commit
that referenced
this pull request
Sep 12, 2022
…evisions (#40892) We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :- a. gRPC fault injection(#39295) b. Ignore port number in domain matching(#40475) c. Tunneling outbound traffic :- new tunnel field got introduced(#37968) d. Fix consistent hash based on source IP for TCP proxy(#38438) e. Traffic policy load balancer API changes(#39742)
istio-testing
pushed a commit
to istio-testing/istio
that referenced
this pull request
Sep 13, 2022
…evisions
We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :-
a. gRPC fault
injection(istio#39295)
b. Ignore port number in domain
matching(istio#40475)
c. Tunneling outbound traffic :- new tunnel field got
introduced(istio#37968)
d. Fix consistent hash based on source IP for TCP
proxy(istio#38438)
e. Traffic policy load balancer API
changes(istio#39742)
istio-testing
added a commit
that referenced
this pull request
Sep 13, 2022
…evisions (#40957) We are adding min istio version for tests related to below PRs as this functionalities were not there in previous revisions :- a. gRPC fault injection(#39295) b. Ignore port number in domain matching(#40475) c. Tunneling outbound traffic :- new tunnel field got introduced(#37968) d. Fix consistent hash based on source IP for TCP proxy(#38438) e. Traffic policy load balancer API changes(#39742) Co-authored-by: Hemendra Teli <hemendrat@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Original PR - #26059
This PR resurrects it and only adds integration test to complete it.
Brief description: This PR adds support to injecting gRPC faults with given status codes. It builds on the original PR which seemed to be abandoned. The actual changes like validation and config-generation were already there in the original PR (full credits to the person who raised it) and was working fine. The only thing I added is the integration test as suggested by @howardjohn in #26059 (comment) .
Once this goes through we have to remove
$hide_from_docsfor thegrpcStatusfield and update the documentation to indicate that users have to specify upper-cased string likeUNAVAILABLEas mentioned in https://github.com/grpc/grpc/blob/master/doc/statuscodes.mdOpen question
OK? This is because it is technically not a fault. We can allow it to be consistent with HTTP, where specifying 200 OK is allowed.