[release-1.14] update prow to 1.24 and fix remote-secret creation #39003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevenctl
commented
May 18, 2022
- prow: update default image to 1.24.0
- wait for token data to be available
- fix lint and release note
- unit test coverage
…stio#38885) * prow: update default image to 1.24.0 Change-Id: I5b8732367af80a948f857a71d14102ca0549436b * wait for token data to be available Change-Id: I1e91d11ade8f053ee05a962372357a5b40627fd5 * fix test Change-Id: Ide970ec6dac60b1020adeeed5955bb5dcf0f69cd * fix lint and release note Change-Id: I8527d0325527899ab20dcf3b01c642c3dac94907 * remove go install Change-Id: I248c3464b478c179f7e9b9a999de42121f88d5e1 * handle err Change-Id: If0496c54b12105110ec93841961c40dd8d11fb49 * unit test coverage Change-Id: I7756310338deb98f9284976cdd11f254424a45a3
lei-tang
approved these changes
May 18, 2022
|
/retest |
Closed
GregHanson
suggested changes
May 18, 2022
| return client.CoreV1().Secrets(opt.Namespace).Create(ctx, &v1.Secret{ | ||
| log.Infof("Creating token secret for service account %q", serviceAccount.Name) | ||
| secretName := tokenSecretName(serviceAccount.Name) | ||
| return client.Kube().CoreV1().Secrets(opt.Namespace).Create(ctx, &v1.Secret{ |
There was a problem hiding this comment.
@stevenctl does this client.CoreV1().Secrets -> client.Kube().CoreV1().Secrets work as expected without the underlying change to pkg/kube/client.go from the original PR?
https://github.com/istio/istio/pull/38789/files#diff-137bba79988de442c1fde0fc29520d6d7e5a5239ceac82f5439a5bf513ebb2d4
There was a problem hiding this comment.
Nope, I think https://github.com/istio/istio/pull/38789/files#diff-137bba79988de442c1fde0fc29520d6d7e5a5239ceac82f5439a5bf513ebb2d4L111
Line 111 in the "before" part of the diff already had the Kube() method returning the embedded client.
There was a problem hiding this comment.
So no behavior change.
|
resolves #38987 |
GregHanson
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.