Skip to content

[release-1.14] Fix analyze conflicting mesh gateway with exportTo #39841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[release-1.14] Fix analyze conflicting mesh gateway with exportTo #39841

wants to merge 4 commits into from

Conversation

istio-testing
Copy link
Collaborator

This is an automated cherry-pick of #39729

@istio-testing istio-testing requested a review from a team July 8, 2022 15:15
@istio-testing istio-testing mentioned this pull request Jul 8, 2022
Merged
11 tasks
@istio-testing istio-testing added the release-notes-none Indicates a PR that does not require release notes. label Jul 8, 2022
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2022
@GregHanson
Copy link
Member

/test unit-tests_istio_release-1.14

@hanxiaop
Copy link
Member

hanxiaop commented Jul 9, 2022

/test unit-tests_istio_release-1.14

@istio-testing
Copy link
Collaborator Author

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_istio_release-1.14 67c6fe1 link true /test unit-tests_istio_release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson
Copy link
Member

@hanxiaop it's the same unit test failing every time - is this fix dependent on another PR that didn't get cherry-picked?

@hanxiaop
Copy link
Member

@hanxiaop it's the same unit test failing every time - is this fix dependent on another PR that didn't get cherry-picked?

@GregHanson I don't think so. I'll check it out. Thanks for reminding.

@ericvn
Copy link
Contributor

ericvn commented Jul 29, 2022

Just a reminder @hanxiaop

@hanxiaop
Copy link
Member

Just a reminder @hanxiaop

@ericvn Thanks! I'll check it out this week.

@hanxiaop hanxiaop mentioned this pull request Jul 31, 2022
Merged
@hanxiaop
Copy link
Member

#40189

@hanxiaop hanxiaop closed this Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@GregHanson GregHanson GregHanson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hanxiaop hanxiaop

Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@istio-testing @GregHanson @hanxiaop @ericvn