Revert changes to always notify XdsUpdater in mem discovery #39721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@howardjohn do we understand the cause of the flakes? Is this something we'll want to fix and roll-forward later? |
|
basically tests do "apply some changes, trigger push, wait for push". But
with my change to always trigger push when there are changes , depending on
debounce they may get a different number of pushes.
It's possible to make the tests more robust but there are a lot like this
and they are somewhat complex to fix so I at least don't have bandwidth to
fix in the short term
…On Thu, Jun 30, 2022, 11:56 AM Nathan Mittler ***@***.***> wrote:
@howardjohn <https://github.com/howardjohn> do we understand the cause of
the flakes? Is this something we'll want to fix and roll-forward later?
—
Reply to this email directly, view it on GitHub
<#39721 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYGXLLLCCR2EFHCRYZGTLVRXUUHANCNFSM52KILSLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
depending on the test it's also reasonable to want to explicitly control
the push to test certain things
…On Thu, Jun 30, 2022, 12:42 PM John Howard ***@***.***> wrote:
basically tests do "apply some changes, trigger push, wait for push". But
with my change to always trigger push when there are changes , depending on
debounce they may get a different number of pushes.
It's possible to make the tests more robust but there are a lot like this
and they are somewhat complex to fix so I at least don't have bandwidth to
fix in the short term
On Thu, Jun 30, 2022, 11:56 AM Nathan Mittler ***@***.***>
wrote:
> @howardjohn <https://github.com/howardjohn> do we understand the cause
> of the flakes? Is this something we'll want to fix and roll-forward later?
>
> —
> Reply to this email directly, view it on GitHub
> <#39721 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAEYGXLLLCCR2EFHCRYZGTLVRXUUHANCNFSM52KILSLQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
nmittler
approved these changes
Jun 30, 2022
hzxuzhonghu
approved these changes
Jul 1, 2022
adiprerepa
approved these changes
Jul 1, 2022
This impacts tests only. In istio#39133 we changed to notify on writes; this ended up triggering a ton of test flake. Instead, just add explicit functions to notify (new test needs them) and revert the other changes
5056eb7 to
420c168
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impacts tests only.
In #39133 we changed to notify on
writes; this ended up triggering a ton of test flake. Instead, just add
explicit functions to notify (new test needs them) and revert the other changes
Please provide a description of this PR: