operator: fix remaining issue for 1.25 in cluster controller #39587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
ping @istio/wg-environments-maintainers |
|
In response to a cherrypick label: new pull request created: #39698 |
istio-testing
pushed a commit
that referenced
this pull request
Jul 13, 2022
* operator: fix 1.25 install (#39554) * operator: fix 1.25 install There were a few issues here: * We always used the old versions for prune, and only sometimes added the new ones. This means on 1.25 we get a bunch of errors * We never based the version to the helm renderer, so its ignored and we always use the old API versions. This PR fixes both of these. A lot of plumbing to get the version through * lint (cherry picked from commit 349c47e) * operator: fix remaining issue for 1.25 in cluster controller (#39587) (cherry picked from commit 89aadd6) * Fix operator test on 1.25 (#39883) (cherry picked from commit 686aa16) * release note
jiangshantao-dbg
pushed a commit
to istio-mt/istio
that referenced
this pull request
Jun 9, 2025
jiangshantao-dbg
added a commit
to istio-mt/istio
that referenced
this pull request
Jun 11, 2025
* feat: cherry pick operator: fix 1.25 install (istio#39554) 349c47e * feat: operator: fix remaining issue for 1.25 in cluster controller (istio#39587) 89aadd6 * feat: ignore replicaCount when autoscale is enabled (istio#36928) 28c8811 * feat: pdb v1 and autoscaler v2 ed2de8c, c3d3d13, 57b90f0 --------- Co-authored-by: jst <jst@meitu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note regarding why we don't see test changes/failures - they are in postsubmit only